From 1fdbfc1a277a788f8317ed47fccda22c587d3363 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sat, 4 Jul 2026 15:26:26 +0900 Subject: fix(pcre): restore missing regex delimiters in ported patterns Several Preg::*() call sites lost their PHP delimiter (and in one case the `i` modifier) during porting, since preg_*() expects the delimiter to be preserved in the caller's pattern literal and stripped internally. This made compile_php_pattern panic or silently misparse the pattern. Un-ignore the Version tests that were blocked by this bug. --- crates/shirabe/src/downloader/zip_downloader.rs | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) (limited to 'crates/shirabe/src/downloader/zip_downloader.rs') diff --git a/crates/shirabe/src/downloader/zip_downloader.rs b/crates/shirabe/src/downloader/zip_downloader.rs index 428ca2a..bc0c9e4 100644 --- a/crates/shirabe/src/downloader/zip_downloader.rs +++ b/crates/shirabe/src/downloader/zip_downloader.rs @@ -112,7 +112,11 @@ impl ZipDownloader { == 0 { let mut m: IndexMap = IndexMap::new(); - if Preg::is_match3(r"^\s*7-Zip(?:\s\[64\])?\s([0-9.]+)", &output, Some(&mut m)) { + if Preg::is_match3( + r"{^\s*7-Zip(?:\s\[64\])?\s([0-9.]+)}", + &output, + Some(&mut m), + ) { let m1 = m.get(&CaptureKey::ByIndex(1)).cloned().unwrap_or_default(); if version_compare(&m1, "21.01", "<") { self.inner.io.write_error(&format!( -- cgit v1.3.1