From 2d474e91e49c7343d28198eff2b5bbbed9afbcee Mon Sep 17 00:00:00 2001
From: nsfisis <nsfisis@gmail.com>
Date: Wed, 10 Jun 2026 02:41:34 +0900
Subject: feat(phase-c): resolve cross-module phase-b TODOs

---
 crates/shirabe/src/downloader/file_downloader.rs | 7 +------
 crates/shirabe/src/downloader/git_downloader.rs  | 3 ---
 2 files changed, 1 insertion(+), 9 deletions(-)

(limited to 'crates/shirabe/src/downloader')

diff --git a/crates/shirabe/src/downloader/file_downloader.rs b/crates/shirabe/src/downloader/file_downloader.rs
index 54b0882..e5112cc 100644
--- a/crates/shirabe/src/downloader/file_downloader.rs
+++ b/crates/shirabe/src/downloader/file_downloader.rs
@@ -551,12 +551,7 @@ impl DownloaderInterface for FileDownloader {
         for bin in package.get_binaries() {
             let bin_path = format!("{}/{}", path, bin);
             if file_exists(&bin_path) && !is_executable(&bin_path) {
-                // TODO(phase-b): Silencer::call_named for native PHP function
-                let _ = Silencer::call(|| {
-                    let _ = bin_path;
-                    let _ = umask();
-                    Ok(())
-                });
+                let _ = Silencer::call(|| Ok(shirabe_php_shim::chmod(&bin_path, 0o777 & !umask())));
             }
         }
 
diff --git a/crates/shirabe/src/downloader/git_downloader.rs b/crates/shirabe/src/downloader/git_downloader.rs
index 7dace1b..47dd959 100644
--- a/crates/shirabe/src/downloader/git_downloader.rs
+++ b/crates/shirabe/src/downloader/git_downloader.rs
@@ -1240,7 +1240,6 @@ impl VcsDownloader for GitDownloader {
             io_interface::NORMAL,
         );
         let slice_end = 10_usize.min(changes.len());
-        // TODO(phase-b): PHP passes the list directly to writeError; joined here so write_error3 takes &str
         self.inner
             .io
             .write_error3(&changes[..slice_end].join("\n"), true, io_interface::NORMAL);
@@ -1291,7 +1290,6 @@ impl VcsDownloader for GitDownloader {
                     .into());
                 }
                 Some("v") => {
-                    // TODO(phase-b): PHP passes list directly; joined here for &str arg
                     self.inner
                         .io
                         .write_error3(&changes.join("\n"), true, io_interface::NORMAL);
@@ -1307,7 +1305,6 @@ impl VcsDownloader for GitDownloader {
 
             if do_help {
                 // help:
-                // TODO(phase-b): PHP passes list directly; joined here for &str arg
                 self.inner.io.write_error3(
                     &[
                         format!(
-- 
cgit v1.3.1