From 6ae7e0d4b3eaf20e2d2cd3d000cf61ab0c9b6e83 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Thu, 11 Jun 2026 02:39:35 +0900 Subject: feat(console): resolve phase-b TODOs in doRun and IO wiring Wire up ConsoleIO with HelperSet/QuestionHelper, register the ErrorHandler with the IO instance, and fall back to a default output in run(). Replace resolved phase-b TODOs across the console, command, io, factory, installer, dependency_resolver, and util modules; reclassify the remaining blockers (typed Symfony command registry, stdin resource caching) as phase-c. Co-Authored-By: Claude Opus 4.8 (1M context) --- crates/shirabe/src/downloader/path_downloader.rs | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) (limited to 'crates/shirabe/src/downloader') diff --git a/crates/shirabe/src/downloader/path_downloader.rs b/crates/shirabe/src/downloader/path_downloader.rs index 66f84b6..6d0e098 100644 --- a/crates/shirabe/src/downloader/path_downloader.rs +++ b/crates/shirabe/src/downloader/path_downloader.rs @@ -472,7 +472,11 @@ impl DownloaderInterface for PathDownloader { ); } let _iterator = ArchivableFilesFinder::new(&real_url, vec![], false)?; - // TODO(phase-b): pass iterator as PhpMixed; ArchivableFilesFinder iterator wrapping not modelled yet. + // PHP: $symfonyFilesystem->mirror($realUrl, $path, $iterator); + // TODO(phase-c): Symfony Filesystem::mirror takes a Traversable iterator as its third + // argument, but the external-package Filesystem stub does not model the iterator type + // that ArchivableFilesFinder (an IteratorAggregate) would be wrapped into, so None is + // passed and the mirrored file list is not restricted. symfony_filesystem.mirror(&real_url, &path, None, &IndexMap::new())?; } -- cgit v1.3.1