From 84655bf3a4a21dbbe7aec8e3aee1e661505bbb6d Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sat, 20 Jun 2026 23:37:42 +0900 Subject: feat(symfony-process): port full Process class from PHP Faithfully port every method, field and constant of Symfony's Process.php into process.rs, replacing the reduced stub. Add the supporting pipes module (PipesInterface/AbstractPipes/UnixPipes/ WindowsPipes), ProcessUtils and the missing process exceptions (LogicException/InvalidArgumentException) with constructors. Methods now return anyhow::Result where PHP throws, take the env argument and a bool-returning callback, and borrow &mut for status-updating accessors; all callers are updated accordingly. Extend the php-shim with proc_open/proc_close (PHP-compatible signatures), proc_get_status, proc_terminate, posix_kill, uniqid, ftruncate, ftell_stream, fseek3, stream_get_contents3 and env helpers. Co-Authored-By: Claude Opus 4.8 --- crates/shirabe/src/downloader/zip_downloader.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'crates/shirabe/src/downloader') diff --git a/crates/shirabe/src/downloader/zip_downloader.rs b/crates/shirabe/src/downloader/zip_downloader.rs index 3d72377..d7508a6 100644 --- a/crates/shirabe/src/downloader/zip_downloader.rs +++ b/crates/shirabe/src/downloader/zip_downloader.rs @@ -135,7 +135,7 @@ impl ZipDownloader { .execute_async(&command, ()) .await; match process_result { - Ok(process) => { + Ok(mut process) => { if !process.is_successful() { if self.cleanup_executed.contains_key(&package.get_name()) { return Err(RuntimeException { @@ -148,7 +148,7 @@ impl ZipDownloader { .into()); } - let output = process.get_error_output(); + let output = process.get_error_output()?; let output = str_replace(&format!(", {}.zip or {}.ZIP", file, file), "", &output); -- cgit v1.3.1