From a9f19862350c6fd3592d93515d869ffe07ecb399 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Thu, 4 Jun 2026 21:08:22 +0900 Subject: feat: resolve trivial todo!() sites with existing constructors Replace todo!("VersionParser::new()") with VersionParser::new() at 6 call sites (array_loader, base_command, create_project_command, vcs_repository, http_downloader x2) and EventDispatcher::io_clone with self.io.clone(). All targets already exist on their types. Co-Authored-By: Claude Opus 4.8 --- crates/shirabe/src/event_dispatcher/event_dispatcher.rs | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'crates/shirabe/src/event_dispatcher') diff --git a/crates/shirabe/src/event_dispatcher/event_dispatcher.rs b/crates/shirabe/src/event_dispatcher/event_dispatcher.rs index 175b689..77d016b 100644 --- a/crates/shirabe/src/event_dispatcher/event_dispatcher.rs +++ b/crates/shirabe/src/event_dispatcher/event_dispatcher.rs @@ -1307,8 +1307,7 @@ impl EventDispatcher { // ---- helpers ---- fn io_clone(&self) -> std::rc::Rc> { - // TODO(phase-b): IOInterface is not Clone — placeholder until io ownership is resolved. - todo!("clone std::rc::Rc>") + self.io.clone() } fn composer(&self) -> PartialComposerHandle { -- cgit v1.3.1