From b8a50e25aafb51a6d73f9695362854cc5ed58117 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sun, 7 Jun 2026 18:26:55 +0900 Subject: feat(phase-c): resolve &mut-access phase-b TODOs via handle setters PHP mutator methods that the Phase B port could not call because only &self / &dyn / Rc access was available. Resolved by the interior-mutation APIs that already exist: handle &self setters (set_dist/source_reference, set_requires/dev/references/stability_flags), Rc> .borrow_mut(), and get_installation_manager().borrow_mut() (build_package_map passes an empty/canonical package list per upstream). composer.get_package() returns &RootPackageInterfaceHandle, so the "&dyn" Phase B note was wrong. factory's set_config_source/set_auth_config_source were already live code; their stale TODOs are removed. Co-Authored-By: Claude Opus 4.8 (1M context) --- crates/shirabe/src/event_dispatcher/event_dispatcher.rs | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) (limited to 'crates/shirabe/src/event_dispatcher') diff --git a/crates/shirabe/src/event_dispatcher/event_dispatcher.rs b/crates/shirabe/src/event_dispatcher/event_dispatcher.rs index bea2e76..797083c 100644 --- a/crates/shirabe/src/event_dispatcher/event_dispatcher.rs +++ b/crates/shirabe/src/event_dispatcher/event_dispatcher.rs @@ -1278,12 +1278,12 @@ impl EventDispatcher { self.previous_hash = Some(hash_value); - // TODO(phase-b): build_package_map needs &mut InstallationManager and returns Result; - // Composer is &Composer here so we cannot take a mut borrow. Defer until shared ownership. - let _ = &generator; - let _ = packages; - let package_map: Vec<(crate::package::PackageInterfaceHandle, Option)> = - todo!("build_package_map requires &mut InstallationManager"); + let installation_manager = composer.get_installation_manager(); + let package_map = generator.build_package_map( + &mut installation_manager.borrow_mut(), + package.clone(), + packages, + )?; // TODO(phase-b): parse_autoloads also expects the filtered dev packages list // (PhpMixed in this port). let map = generator.parse_autoloads( -- cgit v1.3.1