From e93ea9ae1058334fc72b7795021bb42c1bd64401 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Wed, 3 Jun 2026 00:34:01 +0900 Subject: feat(io): add as_any downcast shims for IOInterface and OutputInterface Introduce the cross-cutting downcast base for PHP `instanceof` checks on io/output trait objects: `IOInterface::as_any` (ConsoleIO/NullIO/BufferIO) and `OutputInterface::as_console_output_interface` (promoting ConsoleOutput to a proper ConsoleOutputInterface). Wire the resolved downcasts in ConsoleIO error output, Auditor table format, and the event dispatcher. Co-Authored-By: Claude Opus 4.8 (1M context) --- crates/shirabe/src/event_dispatcher/event_dispatcher.rs | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) (limited to 'crates/shirabe/src/event_dispatcher') diff --git a/crates/shirabe/src/event_dispatcher/event_dispatcher.rs b/crates/shirabe/src/event_dispatcher/event_dispatcher.rs index 237fad4..175b689 100644 --- a/crates/shirabe/src/event_dispatcher/event_dispatcher.rs +++ b/crates/shirabe/src/event_dispatcher/event_dispatcher.rs @@ -609,11 +609,8 @@ impl EventDispatcher { .join(" "); // reusing the output from $this->io is mostly needed for tests, but generally speaking // it does not hurt to keep the same stream as the current Application - // TODO(phase-b): IOInterface needs an `as_any` shim before - // `instanceof ConsoleIO` can be expressed; treat io as a - // generic IOInterface for now. - let downcast: Option<&ConsoleIO> = None; - let output: ConsoleOutput = if let Some(_console_io) = downcast { + let is_console_io = self.io.borrow().as_any().is::(); + let output: ConsoleOutput = if is_console_io { // TODO(plugin): \ReflectionProperty to read private `output` from ConsoleIO // is required by the original PHP — needs user-decided porting strategy. let _refl_php_version_gate = PHP_VERSION_ID < 80100; -- cgit v1.3.1