From 716f44031a39c5e43fb441ecc470db76efc23dd4 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sun, 14 Jun 2026 11:24:36 +0900 Subject: refactor(pcre): drop Result from Preg method return types The Preg methods panic on PCRE failure (per the file header rationale), so their anyhow::Result wrappers never carried an Err. Co-Authored-By: Claude Opus 4.8 --- .../ignore_list_platform_requirement_filter.rs | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'crates/shirabe/src/filter') diff --git a/crates/shirabe/src/filter/platform_requirement_filter/ignore_list_platform_requirement_filter.rs b/crates/shirabe/src/filter/platform_requirement_filter/ignore_list_platform_requirement_filter.rs index d69773c..efa8634 100644 --- a/crates/shirabe/src/filter/platform_requirement_filter/ignore_list_platform_requirement_filter.rs +++ b/crates/shirabe/src/filter/platform_requirement_filter/ignore_list_platform_requirement_filter.rs @@ -48,11 +48,11 @@ impl IgnoreListPlatformRequirementFilter { return Ok(constraint); } - if !allow_upper_bound_override || !Preg::is_match(&self.ignore_upper_bound_regex, req)? { + if !allow_upper_bound_override || !Preg::is_match(&self.ignore_upper_bound_regex, req) { return Ok(constraint); } - if Preg::is_match(&self.ignore_regex, req)? { + if Preg::is_match(&self.ignore_regex, req) { return Ok(MatchAllConstraint::new(None).into()); } @@ -86,14 +86,14 @@ impl PlatformRequirementFilterInterface for IgnoreListPlatformRequirementFilter if !PlatformRepository::is_platform_package(req) { return false; } - Preg::is_match(&self.ignore_regex, req).unwrap_or(false) + Preg::is_match(&self.ignore_regex, req) } fn is_upper_bound_ignored(&self, req: &str) -> bool { if !PlatformRepository::is_platform_package(req) { return false; } - self.is_ignored(req) || Preg::is_match(&self.ignore_upper_bound_regex, req).unwrap_or(false) + self.is_ignored(req) || Preg::is_match(&self.ignore_upper_bound_regex, req) } fn as_any(&self) -> &dyn std::any::Any { -- cgit v1.3.1