From 318ea948f5932dfa7942081a269d62fd7161a9bf Mon Sep 17 00:00:00 2001 From: nsfisis Date: Mon, 8 Jun 2026 01:54:56 +0900 Subject: feat(phase-c): resolve reflection/downcast phase-b TODOs Resolve category F phase-b TODOs (class-string, instanceof, get_class, method_exists, __FILE__, Reflection API, downcast). - VcsRepository: dispatch drivers through a VcsDriverKind enum (instantiate/supports/php_class_name) and add constructors to the concrete VCS drivers - repository downcasts via RepositoryInterfaceHandle::downcast_rc and as_any (init/show commands, vcs ValidatingArrayLoader) - BaseCommand::is_self_update_command override replaces an instanceof - Factory::create narrows PartialComposer to ComposerHandle via as_full - InstalledVersions gains set_self_dir/set_installed_is_local_dir, replacing Reflection-based static property mutation - ClassLoader::as_array_iter ports the PHP (array) cast - drop the unnecessary __FILE__ phar branch in self-update application get_class(command) reclassified TODO(plugin); buffer_io StreamableInputInterface downcast and the ValidatingArrayLoader trait redesign left as tracked TODOs. Co-Authored-By: Claude Opus 4.8 (1M context) --- crates/shirabe/src/installed_versions.rs | 10 ++++++++++ 1 file changed, 10 insertions(+) (limited to 'crates/shirabe/src/installed_versions.rs') diff --git a/crates/shirabe/src/installed_versions.rs b/crates/shirabe/src/installed_versions.rs index 77d653f..fb6e8bf 100644 --- a/crates/shirabe/src/installed_versions.rs +++ b/crates/shirabe/src/installed_versions.rs @@ -423,6 +423,16 @@ impl InstalledVersions { *INSTALLED_IS_LOCAL_DIR.lock().unwrap() = false; } + /// PHP mutates the private static `$selfDir` via Reflection. Rust exposes a mutating function. + pub fn set_self_dir(dir: String) { + *SELF_DIR.lock().unwrap() = Some(dir); + } + + /// PHP mutates the private static `$installedIsLocalDir` via Reflection. Rust exposes a mutating function. + pub fn set_installed_is_local_dir(value: bool) { + *INSTALLED_IS_LOCAL_DIR.lock().unwrap() = value; + } + /// @return string fn get_self_dir() -> String { let mut self_dir = SELF_DIR.lock().unwrap(); -- cgit v1.3.1