From 3b28fc65f5de7c6ad69bee48b2d1f52dd9b30972 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Mon, 29 Jun 2026 02:16:43 +0900 Subject: fix(advisory): pass IO as shared handle to Auditor::audit Auditor::audit took io as &mut dyn IOInterface, forcing the audit and installer post-audit call sites to hold a borrow_mut() on the shared IO RefCell for the whole call. During advisory fetching the repositories write to their own clones of the same handle, so the borrow_mut() collided with their borrow() and panicked with 'RefCell already mutably borrowed' on 'audit --locked'. Take the Rc> handle instead so writes borrow briefly and never overlap. Un-ignore the locked-audit regression test that this unblocks. Co-Authored-By: Claude Opus 4.8 (1M context) --- crates/shirabe/src/installer.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'crates/shirabe/src/installer.rs') diff --git a/crates/shirabe/src/installer.rs b/crates/shirabe/src/installer.rs index f051563..1e72a94 100644 --- a/crates/shirabe/src/installer.rs +++ b/crates/shirabe/src/installer.rs @@ -517,7 +517,7 @@ impl Installer { } let audit_result = auditor.audit( - &mut *self.io.borrow_mut(), + &self.io, &repo_set, packages, &audit_config.audit_format, -- cgit v1.3.1