From 20f9787cda5b846c730cff97a4c7a3777ff3414a Mon Sep 17 00:00:00 2001
From: nsfisis <nsfisis@gmail.com>
Date: Mon, 24 Aug 2026 21:07:26 +0900
Subject: refactor(silencer): stop guarding work that stays inside Rust

Silencer only lowers the PHP error_reporting() level and re-throws
whatever the guarded work raises. A region that never reaches the PHP
runtime has no level to lower and emits no diagnostic on failure, so
wrapping it is indistinguishable from running it unguarded.

The pair kept in Application::hint_common_errors brackets a
getComposer() call, which loads installed plugins and dispatches
PluginEvents::INIT.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
---
 crates/shirabe/src/installer/binary_installer.rs | 24 ++++--------------------
 1 file changed, 4 insertions(+), 20 deletions(-)

(limited to 'crates/shirabe/src/installer/binary_installer.rs')

diff --git a/crates/shirabe/src/installer/binary_installer.rs b/crates/shirabe/src/installer/binary_installer.rs
index 1f70a5ca..2da360d2 100644
--- a/crates/shirabe/src/installer/binary_installer.rs
+++ b/crates/shirabe/src/installer/binary_installer.rs
@@ -7,7 +7,6 @@ use crate::package::PackageInterfaceHandle;
 use crate::util::Filesystem;
 use crate::util::Platform;
 use crate::util::ProcessExecutor;
-use crate::util::Silencer;
 use shirabe_php_shim::{
     basename, basename_with_suffix, chmod, dirname, fclose, fgets, file_exists,
     file_get_contents_with_max_length, file_put_contents, fopen, is_dir, is_file, is_link,
@@ -152,10 +151,7 @@ impl BinaryInstaller {
             } else {
                 self.install_unixy_proxy_binaries(&bin_path, &link);
             }
-            let _ = Silencer::call(|| {
-                chmod(&bin_path, 0o777 & !umask());
-                Ok(())
-            });
+            chmod(&bin_path, 0o777 & !umask());
         }
     }
 
@@ -179,11 +175,7 @@ impl BinaryInstaller {
 
         // attempt removing the bin dir in case it is left empty
         if is_dir(&self.bin_dir) && self.filesystem.borrow_mut().is_dir_empty(&self.bin_dir) {
-            let bin_dir = self.bin_dir.clone();
-            let _ = Silencer::call(|| {
-                rmdir(&bin_dir);
-                Ok(())
-            });
+            let _ = rmdir(&self.bin_dir);
         }
     }
 
@@ -241,22 +233,14 @@ impl BinaryInstaller {
         if !file_exists(&link) {
             let code = self.generate_windows_proxy_code(bin_path, &link);
             file_put_contents(&link, code.as_bytes());
-            let link_clone = link.clone();
-            let _ = Silencer::call(|| {
-                chmod(&link_clone, 0o777 & !umask());
-                Ok(())
-            });
+            chmod(&link, 0o777 & !umask());
         }
     }
 
     fn install_unixy_proxy_binaries(&self, bin_path: &str, link: &str) {
         let code = self.generate_unixy_proxy_code(bin_path, link);
         file_put_contents(link, code.as_bytes());
-        let link_owned = link.to_string();
-        let _ = Silencer::call(|| {
-            chmod(&link_owned, 0o777 & !umask());
-            Ok(())
-        });
+        chmod(link, 0o777 & !umask());
     }
 
     fn initialize_bin_dir(&mut self) {
-- 
cgit v1.3.1-4-g156e