From e093b2be1c333e67c96aebb0a5291bea9ae3d6db Mon Sep 17 00:00:00 2001 From: nsfisis Date: Tue, 18 Aug 2026 01:57:02 +0900 Subject: refactor(preg): drop the offset argument from preg_match Every call site but one passed offset 0. The remaining one, the UTF-8 chunking loop in Application, slices the subject instead: its pattern has no anchor or lookaround, so matching a suffix is equivalent to starting the search at that offset. Co-Authored-By: Claude Opus 5 (1M context) --- crates/shirabe/src/installer/binary_installer.rs | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) (limited to 'crates/shirabe/src/installer/binary_installer.rs') diff --git a/crates/shirabe/src/installer/binary_installer.rs b/crates/shirabe/src/installer/binary_installer.rs index 4e3b5e4c..554620df 100644 --- a/crates/shirabe/src/installer/binary_installer.rs +++ b/crates/shirabe/src/installer/binary_installer.rs @@ -10,7 +10,7 @@ use crate::util::ProcessExecutor; use crate::util::Silencer; use shirabe_php_shim::{ PhpMixed, basename, basename_with_suffix, chmod, dirname, fclose, fgets, file_exists, - file_get_contents5, file_put_contents, fopen, is_dir, is_file, is_link, php_regex, preg_match2, + file_get_contents5, file_put_contents, fopen, is_dir, is_file, is_link, php_regex, preg_match, realpath, rmdir, substr, trim, umask, }; @@ -200,10 +200,9 @@ impl BinaryInstaller { } Err(_) => String::new(), }; - if let Some(m) = preg_match2( + if let Some(m) = preg_match( php_regex!(r"{^#!/(?:usr/bin/env )?(?:[^/]+/)*(.+)$}m"), &line, - 0, ) { return trim(m.get(1).unwrap_or(""), None); } @@ -316,10 +315,9 @@ impl BinaryInstaller { file_get_contents5(bin, false, PhpMixed::Null, 0, Some(500)).unwrap_or_default(); // For php files, we generate a PHP proxy instead of a shell one, // which allows calling the proxy with a custom php process - if let Some(m) = preg_match2( + if let Some(m) = preg_match( php_regex!(r"{^(#!.*\r?\n)?[\r\n\t ]*<\?php}"), &bin_contents, - 0, ) { // carry over the existing shebang if present, otherwise add our own let proxy_code = match m.get(1) { -- cgit v1.3.1-4-g156e