From 9efc866ae2553a9c51abae7214f62dde4f5f053c Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sun, 2 Aug 2026 16:27:36 +0900 Subject: chore(todo): consolidate TODO comments into the five fixed marker tags Retag every Shirabe-authored TODO comment to one of the fixed tags: phase-c, phase-d, plugin, php-runtime, phase-e. Upstream-authored TODO comments from Composer/Symfony are left untouched to preserve the ported code shape. Co-Authored-By: Claude Fable 5 --- crates/shirabe/src/installer/installation_manager.rs | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'crates/shirabe/src/installer/installation_manager.rs') diff --git a/crates/shirabe/src/installer/installation_manager.rs b/crates/shirabe/src/installer/installation_manager.rs index 3a04a8e9..cf75469c 100644 --- a/crates/shirabe/src/installer/installation_manager.rs +++ b/crates/shirabe/src/installer/installation_manager.rs @@ -308,9 +308,9 @@ impl InstallationManager { SignalHandler::SIGTERM.to_string(), SignalHandler::SIGHUP.to_string(), ], - // TODO(phase-b): closure captures &mut self via &mut cleanup_promises + // TODO(phase-c): closure captures &mut self via &mut cleanup_promises Box::new(move |signal: String, handler: &SignalHandler| { - // TODO(phase-b): self.io.write_error(...); self.run_cleanup(&cleanup_promises); + // TODO(phase-c): self.io.write_error(...); self.run_cleanup(&cleanup_promises); let _ = signal; handler.exit_with_last_signal(); }), @@ -802,7 +802,7 @@ impl InstallationManager { return; } - // TODO(phase-c-promise): PHP collects every http_downloader.add() promise and runs them via + // TODO(phase-c): PHP collects every http_downloader.add() promise and runs them via // Loop::wait; the single-threaded sync bridge block_on's each notification serially instead. let result: anyhow::Result<()> = (|| -> anyhow::Result<()> { for (repo_url, packages) in self.notifiable_packages.borrow().iter() { @@ -929,7 +929,7 @@ impl InstallationManager { /// PHP: waitOnPromises() creates a ProgressBar up front and Loop::wait advances it while the /// concurrent promises resolve. - /// TODO(phase-c-promise): Loop::wait has no active-job counter to feed the bar yet, so a + /// TODO(phase-c): Loop::wait has no active-job counter to feed the bar yet, so a /// single 0% -> 100% jump is rendered after the wait instead of PHP's timing-driven /// intermediate snapshots. async fn wait_on_promises<'p>( -- cgit v1.3.1