From 436e12381dd79e419dce755718be17b66d73e17f Mon Sep 17 00:00:00 2001 From: nsfisis Date: Tue, 9 Jun 2026 00:09:08 +0900 Subject: feat(event-dispatcher): unify event dispatch via EventInterface trait Extract a superclass-trait EventInterface from the base Event. pool_builder's PrePoolCreateEvent stays deferred: its constructor needs owned, non-cloneable Request and repository boxes the builder only holds by reference (owned-payload blocker). The event is plugin-only, so its construction is re-tagged TODO(plugin). Co-Authored-By: Claude Opus 4.8 (1M context) --- crates/shirabe/src/installer/installer_event.rs | 26 +++++++++++++++++++++++++ crates/shirabe/src/installer/package_event.rs | 24 +++++++++++++++++++++++ 2 files changed, 50 insertions(+) (limited to 'crates/shirabe/src/installer') diff --git a/crates/shirabe/src/installer/installer_event.rs b/crates/shirabe/src/installer/installer_event.rs index 5adde1c..ca0be22 100644 --- a/crates/shirabe/src/installer/installer_event.rs +++ b/crates/shirabe/src/installer/installer_event.rs @@ -1,8 +1,12 @@ //! ref: composer/src/Composer/Installer/InstallerEvent.php +use indexmap::IndexMap; +use shirabe_php_shim::PhpMixed; + use crate::composer::ComposerWeakHandle; use crate::dependency_resolver::Transaction; use crate::event_dispatcher::Event; +use crate::event_dispatcher::EventInterface; use crate::io::IOInterface; #[derive(Debug)] @@ -55,3 +59,25 @@ impl InstallerEvent { Some(&self.transaction) } } + +impl EventInterface for InstallerEvent { + fn get_name(&self) -> &str { + self.inner.get_name() + } + + fn get_arguments(&self) -> &Vec { + self.inner.get_arguments() + } + + fn get_flags(&self) -> &IndexMap { + self.inner.get_flags() + } + + fn is_propagation_stopped(&self) -> bool { + self.inner.is_propagation_stopped() + } + + fn stop_propagation(&mut self) { + self.inner.stop_propagation(); + } +} diff --git a/crates/shirabe/src/installer/package_event.rs b/crates/shirabe/src/installer/package_event.rs index 17f9113..6661e0d 100644 --- a/crates/shirabe/src/installer/package_event.rs +++ b/crates/shirabe/src/installer/package_event.rs @@ -3,9 +3,11 @@ use crate::composer::ComposerWeakHandle; use crate::dependency_resolver::operation::OperationInterface; use crate::event_dispatcher::Event; +use crate::event_dispatcher::EventInterface; use crate::io::IOInterface; use crate::repository::RepositoryInterface; use indexmap::IndexMap; +use shirabe_php_shim::PhpMixed; #[derive(Debug)] pub struct PackageEvent { @@ -67,3 +69,25 @@ impl PackageEvent { self.operation.as_ref() } } + +impl EventInterface for PackageEvent { + fn get_name(&self) -> &str { + self.inner.get_name() + } + + fn get_arguments(&self) -> &Vec { + self.inner.get_arguments() + } + + fn get_flags(&self) -> &IndexMap { + self.inner.get_flags() + } + + fn is_propagation_stopped(&self) -> bool { + self.inner.is_propagation_stopped() + } + + fn stop_propagation(&mut self) { + self.inner.stop_propagation(); + } +} -- cgit v1.3.1