From 9e5bb3e4253dda96345f4d1a3421077a72295048 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sat, 15 Aug 2026 09:10:16 +0900 Subject: refactor(php-shim): take only the data argument in http_build_query `http_build_query` ignores `numeric_prefix` because a string-keyed slice never holds an integer key, and every caller passes `"&"` as the separator. Drop both parameters and hard-code the separator. Callers that pass a map of scalar literals to `http_build_query_mixed` no longer need to build an `IndexMap` for it, so move them to the slice form. Co-Authored-By: Claude Opus 5 (1M context) --- crates/shirabe/src/installer/installation_manager.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'crates/shirabe/src/installer') diff --git a/crates/shirabe/src/installer/installation_manager.rs b/crates/shirabe/src/installer/installation_manager.rs index 2d21fb54..a9e66ccb 100644 --- a/crates/shirabe/src/installer/installation_manager.rs +++ b/crates/shirabe/src/installer/installation_manager.rs @@ -867,7 +867,7 @@ impl InstallationManager { .collect(); http.insert( "content".to_string(), - PhpMixed::String(http_build_query(¶ms_vec, "", "&")), + PhpMixed::String(http_build_query(¶ms_vec)), ); http.insert("timeout".to_string(), PhpMixed::Int(3)); opts.insert( -- cgit v1.3.1-4-g156e