From 716f44031a39c5e43fb441ecc470db76efc23dd4 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sun, 14 Jun 2026 11:24:36 +0900 Subject: refactor(pcre): drop Result from Preg method return types The Preg methods panic on PCRE failure (per the file header rationale), so their anyhow::Result wrappers never carried an Err. Co-Authored-By: Claude Opus 4.8 --- crates/shirabe/src/io/buffer_io.rs | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) (limited to 'crates/shirabe/src/io/buffer_io.rs') diff --git a/crates/shirabe/src/io/buffer_io.rs b/crates/shirabe/src/io/buffer_io.rs index 8c10dee..91fdac1 100644 --- a/crates/shirabe/src/io/buffer_io.rs +++ b/crates/shirabe/src/io/buffer_io.rs @@ -107,9 +107,7 @@ impl BufferIO { &output, ); - // TODO(phase-c): Preg::replace_callback returns Result; PHP getOutput returns the - // string directly, so this is gated on the get_stream PhpResource model above. - output.unwrap_or_default() + output } pub fn set_user_inputs(&mut self, inputs: Vec) -> Result<()> { -- cgit v1.3.1