From fed0a6e7ac361af9b963c1f62411b1a85478230c Mon Sep 17 00:00:00 2001 From: nsfisis Date: Tue, 18 Aug 2026 01:57:02 +0900 Subject: refactor(preg): add preg_is_match for existence-only call sites The capture groups were discarded at 162 of the preg_match call sites, which only tested the Option. They now call preg_is_match, which lets the regex engine skip capture tracking. Co-Authored-By: Claude Opus 5 (1M context) --- crates/shirabe/src/json/json_file.rs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'crates/shirabe/src/json/json_file.rs') diff --git a/crates/shirabe/src/json/json_file.rs b/crates/shirabe/src/json/json_file.rs index 8d992449..fed8318d 100644 --- a/crates/shirabe/src/json/json_file.rs +++ b/crates/shirabe/src/json/json_file.rs @@ -13,8 +13,8 @@ use shirabe_php_shim::{ InvalidArgumentException, JSON_PRETTY_PRINT, JSON_UNESCAPED_SLASHES, JSON_UNESCAPED_UNICODE, PhpMixed, PregMatches, RuntimeException, UnexpectedValueException, dirname, file_exists, file_get_contents, file_put_contents, is_dir, is_file, json_decode_assoc, json_decode_obj, - json_encode_ex, mkdir, php_regex, preg_match, preg_replace_callback, preg_replace2, realpath, - str_repeat, strlen, strpos, usleep, + json_encode_ex, mkdir, php_regex, preg_is_match, preg_match, preg_replace_callback, + preg_replace2, realpath, str_repeat, strlen, strpos, usleep, }; use shirabe_seld_json_lint::{ParsingException, ParsingExceptionDetails}; @@ -107,7 +107,7 @@ impl JsonFile { http_downloader: Option>>, io: Option>>, ) -> anyhow::Result { - if http_downloader.is_none() && preg_match(php_regex!(r"{^https?://}i"), &path).is_some() { + if http_downloader.is_none() && preg_is_match(php_regex!(r"{^https?://}i"), &path) { return Err(InvalidArgumentException::new( "http urls require a HttpDownloader instance to be passed".to_string(), ) -- cgit v1.3.1-4-g156e