From 0b48f4a46d24248e4c012ef37d25b5963c27a78c Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sun, 23 Aug 2026 12:43:10 +0900 Subject: fix(fs): carry file_get_contents results as bytes file_get_contents() and file_get_contents_with_max_length() return Vec instead of a from_utf8_lossy'd String. Call sites whose consumer takes a &str still convert lossily and are marked TODO(bytes). file_get_contents_with_max_length() now reads at most the requested number of bytes instead of the whole file. Co-Authored-By: Claude Opus 5 (1M context) --- crates/shirabe/src/json/json_file.rs | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) (limited to 'crates/shirabe/src/json') diff --git a/crates/shirabe/src/json/json_file.rs b/crates/shirabe/src/json/json_file.rs index c4a06d77..703b9fbb 100644 --- a/crates/shirabe/src/json/json_file.rs +++ b/crates/shirabe/src/json/json_file.rs @@ -165,7 +165,11 @@ impl JsonFile { io_interface::NORMAL, ); } - Ok(file_get_contents(&self.path)) + // TODO(bytes): the JSON text travels as a String, as it does on the + // HttpDownloader branch above. + Ok(file_get_contents(&self.path) + .map(|c| String::from_utf8_lossy(&c).into_owned()) + .ok()) } })() { Ok(j) => j, @@ -282,10 +286,10 @@ impl JsonFile { content: &str, ) -> anyhow::Result> { // PHP: @file_get_contents($path) - let current_content = Silencer::call(|| Ok(file_get_contents(path))) + let current_content = Silencer::call(|| Ok(file_get_contents(path).ok())) .ok() .flatten(); - if current_content.is_none() || current_content.as_deref() != Some(content) { + if current_content.is_none() || current_content.as_deref() != Some(content.as_bytes()) { return Ok(file_put_contents(path, content.as_bytes())); } @@ -307,7 +311,9 @@ impl JsonFile { )) .into()); } - let content = file_get_contents(&self.path).unwrap_or_default(); + // TODO(bytes): json_decode_obj and validate_syntax take the JSON as a &str. + let content = String::from_utf8_lossy(&file_get_contents(&self.path).unwrap_or_default()) + .into_owned(); let data = json_decode_obj(&content)?; if matches!(data, PhpMixed::Null) && content != "null" { -- cgit v1.3.1-4-g156e