From 3a388b98a9aa6a14b1c7f7dc909c109cf9837800 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sun, 16 Aug 2026 00:59:54 +0900 Subject: refactor: narrow pub(crate) items to private Porting mapped every PHP `protected` member onto `pub(crate)`, which is wider than nearly all of them need. Each item demoted here is reached only from the module that defines it, so the crate-wide visibility conveyed nothing. Every `pub(crate)` that survives has at least one reader in another module of the same crate. Co-Authored-By: Claude Opus 5 (1M context) --- crates/shirabe/src/json/json_file.rs | 2 +- crates/shirabe/src/json/json_manipulator.rs | 2 +- crates/shirabe/src/json/json_validation_exception.rs | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) (limited to 'crates/shirabe/src/json') diff --git a/crates/shirabe/src/json/json_file.rs b/crates/shirabe/src/json/json_file.rs index 652f1d89..78ed76d7 100644 --- a/crates/shirabe/src/json/json_file.rs +++ b/crates/shirabe/src/json/json_file.rs @@ -516,7 +516,7 @@ impl JsonFile { /// @throws \UnexpectedValueException /// @throws ParsingException /// @return bool true on success - pub(crate) fn validate_syntax(json: &str, file: Option<&str>) -> anyhow::Result { + fn validate_syntax(json: &str, file: Option<&str>) -> anyhow::Result { // TODO(php-semantics): make json_decode() returns an error object with details. let error = match serde_json::from_str::(json) { Ok(_) => { diff --git a/crates/shirabe/src/json/json_manipulator.rs b/crates/shirabe/src/json/json_manipulator.rs index 2fa4fe8f..766137ca 100644 --- a/crates/shirabe/src/json/json_manipulator.rs +++ b/crates/shirabe/src/json/json_manipulator.rs @@ -1546,7 +1546,7 @@ impl JsonManipulator { JsonFile::encode(&data) } - pub(crate) fn detect_indenting(&mut self) { + fn detect_indenting(&mut self) { self.indent = JsonFile::detect_indenting(Some(&self.contents)); } } diff --git a/crates/shirabe/src/json/json_validation_exception.rs b/crates/shirabe/src/json/json_validation_exception.rs index cb7370d2..27661e38 100644 --- a/crates/shirabe/src/json/json_validation_exception.rs +++ b/crates/shirabe/src/json/json_validation_exception.rs @@ -5,7 +5,7 @@ use shirabe_php_shim::Exception; #[derive(Debug)] pub struct JsonValidationException { inner: Exception, - pub(crate) errors: Vec, + errors: Vec, } impl JsonValidationException { -- cgit v1.3.1-4-g156e