From cd7c3fce2472656b2a1247429751e43350976677 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Wed, 19 Aug 2026 23:45:38 +0900 Subject: perf(package): hand out link maps behind Rc PackageInterface::getRequires() and friends return the array of Link objects; in PHP that is a copy-on-write array of object references, so a caller pays nothing to look at it. The port returned IndexMap by value, so every call deep-cloned the whole map, keys and constraints included. Pool building calls these accessors once per package per candidate, which put IndexMap::clone at 13.5% of `require laravel/laravel`. Store the maps as Rc> and return a handle. Callers that mutate the map clone it explicitly at the point of mutation, matching where PHP would separate the array. Co-Authored-By: Claude Opus 5 (1M context) --- crates/shirabe/src/package/complete_package.rs | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) (limited to 'crates/shirabe/src/package/complete_package.rs') diff --git a/crates/shirabe/src/package/complete_package.rs b/crates/shirabe/src/package/complete_package.rs index 00b4a67c..b21edb44 100644 --- a/crates/shirabe/src/package/complete_package.rs +++ b/crates/shirabe/src/package/complete_package.rs @@ -279,24 +279,24 @@ impl PackageInterface for CompletePackage { self.inner.get_stability() } - fn get_requires(&self) -> IndexMap { - self.inner.get_requires().clone() + fn get_requires(&self) -> std::rc::Rc> { + PackageInterface::get_requires(&self.inner) } - fn get_conflicts(&self) -> IndexMap { - self.inner.get_conflicts().clone() + fn get_conflicts(&self) -> std::rc::Rc> { + PackageInterface::get_conflicts(&self.inner) } - fn get_provides(&self) -> IndexMap { - self.inner.get_provides().clone() + fn get_provides(&self) -> std::rc::Rc> { + PackageInterface::get_provides(&self.inner) } - fn get_replaces(&self) -> IndexMap { - self.inner.get_replaces().clone() + fn get_replaces(&self) -> std::rc::Rc> { + PackageInterface::get_replaces(&self.inner) } - fn get_dev_requires(&self) -> IndexMap { - self.inner.get_dev_requires().clone() + fn get_dev_requires(&self) -> std::rc::Rc> { + PackageInterface::get_dev_requires(&self.inner) } fn get_suggests(&self) -> IndexMap { -- cgit v1.3.1-4-g156e