From 98af76dbe2815c95d15c20e0f911c4a420b6d848 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sat, 20 Jun 2026 02:45:02 +0900 Subject: feat(package): implement as_package_interface upcast Make the Rust-only as_package_interface a required trait method and return self from each concrete implementation, replacing the todo!() default that PHP needs no equivalent for (implicit subtype coercion). Co-Authored-By: Claude Opus 4.8 (1M context) --- crates/shirabe/src/package/complete_package_interface.rs | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) (limited to 'crates/shirabe/src/package/complete_package_interface.rs') diff --git a/crates/shirabe/src/package/complete_package_interface.rs b/crates/shirabe/src/package/complete_package_interface.rs index 549aeb4..8a7ee25 100644 --- a/crates/shirabe/src/package/complete_package_interface.rs +++ b/crates/shirabe/src/package/complete_package_interface.rs @@ -56,7 +56,5 @@ pub trait CompletePackageInterface: PackageInterface { fn set_archive_excludes(&mut self, excludes: Vec); - fn as_package_interface(&self) -> &dyn crate::package::PackageInterface { - todo!() - } + fn as_package_interface(&self) -> &dyn crate::package::PackageInterface; } -- cgit v1.3.1