From 20d665bb1247500d514f05b160d01f5f8e223a38 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Thu, 4 Jun 2026 22:37:18 +0900 Subject: feat(loader): wire RootPackageLoader::load end-to-end Resolve the remaining todo!()/placeholder sites in RootPackageLoader::load so the root package loads with real data: - Unbox config at use sites and change load()'s parameter from IndexMap> to IndexMap, matching ArrayLoader::load / VersionGuesser::guess_version and dropping the redundant box/unbox round-trip at the factory call site. - Expose replace_version through CompletePackage/RootPackage inherent delegation and a RootPackageHandle method (PHP Package::replaceVersion, inherited), and apply it for the auto-versioned default. - Collect require/require-dev links via getter dispatch and build the pretty-string map feeding extractAliases/StabilityFlags/References. Also reconcile the package repositories type with Config: change CompletePackageInterface::{get,set}_repositories from Vec> to IndexMap (PHP's array), wire setRepositories(config.getRepositories()), and dump repositories verbatim as a keyed array (matching PHP ArrayDumper) instead of forcing a list. Co-Authored-By: Claude Opus 4.8 --- crates/shirabe/src/package/handle.rs | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) (limited to 'crates/shirabe/src/package/handle.rs') diff --git a/crates/shirabe/src/package/handle.rs b/crates/shirabe/src/package/handle.rs index ab1bd0f..2e723b3 100644 --- a/crates/shirabe/src/package/handle.rs +++ b/crates/shirabe/src/package/handle.rs @@ -726,7 +726,7 @@ macro_rules! impl_complete_package_interface_handle { pub fn get_repositories( &self, - ) -> Vec> { + ) -> indexmap::IndexMap { self.0 .borrow() .as_complete_package_interface() @@ -736,7 +736,7 @@ macro_rules! impl_complete_package_interface_handle { pub fn set_repositories( &self, - repositories: Vec>, + repositories: indexmap::IndexMap, ) { self.0 .borrow_mut() @@ -1387,6 +1387,13 @@ impl RootPackageHandle { pub fn new(name: String, version: String, pretty_version: String) -> Self { Self::from_root_package(RootPackage::new(name, version, pretty_version)) } + + pub fn replace_version(&self, version: String, pretty_version: String) { + match &mut *self.0.borrow_mut() { + AnyPackage::RootPackage(p) => p.replace_version(version, pretty_version), + _ => unreachable!("RootPackageHandle invariant"), + } + } } impl AliasPackageHandle { -- cgit v1.3.1