From 1c0eb589741de4aa52ef941ff9315b34dbe48aa0 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Tue, 9 Jun 2026 00:00:12 +0900 Subject: feat(datetime): resolve datetime TODOs Introduce shim functions and constants, replacing the ad-hoc chrono format strings and parse helpers used as phase-b placeholders. Co-Authored-By: Claude Opus 4.8 (1M context) --- crates/shirabe/src/package/loader/array_loader.rs | 15 ++++----------- 1 file changed, 4 insertions(+), 11 deletions(-) (limited to 'crates/shirabe/src/package/loader/array_loader.rs') diff --git a/crates/shirabe/src/package/loader/array_loader.rs b/crates/shirabe/src/package/loader/array_loader.rs index d2aeac6..4df022b 100644 --- a/crates/shirabe/src/package/loader/array_loader.rs +++ b/crates/shirabe/src/package/loader/array_loader.rs @@ -1,12 +1,12 @@ //! ref: composer/src/Composer/Package/Loader/ArrayLoader.php use anyhow::Result; -use chrono::{DateTime, TimeZone, Utc}; +use chrono::Utc; use indexmap::IndexMap; use shirabe_external_packages::composer::pcre::Preg; use shirabe_php_shim::{ - E_USER_DEPRECATED, Exception, PhpMixed, UnexpectedValueException, is_scalar, is_string, - json_encode, ltrim, sprintf, stripos, strpos, strtolower, strval, substr, trigger_error, trim, + E_USER_DEPRECATED, PhpMixed, UnexpectedValueException, is_scalar, is_string, json_encode, + ltrim, sprintf, stripos, strpos, strtolower, strval, substr, trigger_error, trim, }; use crate::package::CompleteAliasPackageHandle; @@ -527,14 +527,7 @@ impl ArrayLoader { time_str.to_string() }; - let result: std::result::Result, Exception> = - // TODO(phase-b): port PHP `new \DateTime($time, new \DateTimeZone('UTC'))` - Utc.datetime_from_str(&time, "%Y-%m-%dT%H:%M:%S%z") - .map_err(|e| Exception { - message: e.to_string(), - code: 0, - }); - if let Ok(date) = result { + if let Ok(date) = shirabe_php_shim::date_create::(&time) { package.package_mut().set_release_date(Some(date)); } } -- cgit v1.3.1