From a9f19862350c6fd3592d93515d869ffe07ecb399 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Thu, 4 Jun 2026 21:08:22 +0900 Subject: feat: resolve trivial todo!() sites with existing constructors Replace todo!("VersionParser::new()") with VersionParser::new() at 6 call sites (array_loader, base_command, create_project_command, vcs_repository, http_downloader x2) and EventDispatcher::io_clone with self.io.clone(). All targets already exist on their types. Co-Authored-By: Claude Opus 4.8 --- crates/shirabe/src/package/loader/array_loader.rs | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) (limited to 'crates/shirabe/src/package/loader/array_loader.rs') diff --git a/crates/shirabe/src/package/loader/array_loader.rs b/crates/shirabe/src/package/loader/array_loader.rs index 634bef8..744b40a 100644 --- a/crates/shirabe/src/package/loader/array_loader.rs +++ b/crates/shirabe/src/package/loader/array_loader.rs @@ -36,10 +36,7 @@ impl ArrayLoader { pub fn new(parser: Option, load_options: bool) -> Self { let parser = match parser { Some(p) => p, - None => { - // TODO(phase-b): VersionParser has no public `new` yet - todo!("VersionParser::new()") - } + None => VersionParser::new(), }; Self { version_parser: parser, -- cgit v1.3.1