From 06e8e14520a4a38fed500581d2b75a42418b22c4 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Thu, 4 Jun 2026 21:09:02 +0900 Subject: feat(package): implement PackageInterface accessor layer for Package/CompletePackage/RootPackage Fill the trait-impl todo!() across the package accessor layer so loaded packages are actually usable (the ArrayLoader::load path depends on it): - Package: implement BasePackage/PackageInterface from struct fields and existing inherent methods; Display via get_unique_name. - CompletePackage: delegate PackageInterface to inner Package. - RootPackage: delegate CompletePackageInterface/PackageInterface to inner CompletePackage; RootPackageInterface link setters delegate to Package. Correct three unfaithful trait signatures found during implementation: - get_target_dir returns Option (PHP computes a normalized value; a borrow cannot represent it, and AliasPackage could not implement &str across its aliasOf handle). - RootPackageInterface link setters take IndexMap, matching Package and the real ArrayLoader caller (PHP RootPackage inherits Package::setRequires; the Link[] docblock was imprecise). - get_full_pretty_version takes a DisplayMode enum instead of a raw i64; the match is now exhaustive, so it returns String without an error path. Move mirror conversion to the boundaries: PackageInterface mirror methods use Vec (the typed form, matching the inherent methods), with array<->Mirror conversion done by the producer (ComposerRepository) and consumer (ArrayDumper). Co-Authored-By: Claude Opus 4.8 --- crates/shirabe/src/package/root_package_interface.rs | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) (limited to 'crates/shirabe/src/package/root_package_interface.rs') diff --git a/crates/shirabe/src/package/root_package_interface.rs b/crates/shirabe/src/package/root_package_interface.rs index 5f47232..aa2534a 100644 --- a/crates/shirabe/src/package/root_package_interface.rs +++ b/crates/shirabe/src/package/root_package_interface.rs @@ -21,15 +21,15 @@ pub trait RootPackageInterface: CompletePackageInterface { fn get_config(&self) -> &IndexMap; - fn set_requires(&mut self, requires: Vec); + fn set_requires(&mut self, requires: IndexMap); - fn set_dev_requires(&mut self, dev_requires: Vec); + fn set_dev_requires(&mut self, dev_requires: IndexMap); - fn set_conflicts(&mut self, conflicts: Vec); + fn set_conflicts(&mut self, conflicts: IndexMap); - fn set_provides(&mut self, provides: Vec); + fn set_provides(&mut self, provides: IndexMap); - fn set_replaces(&mut self, replaces: Vec); + fn set_replaces(&mut self, replaces: IndexMap); fn set_autoload(&mut self, autoload: IndexMap); -- cgit v1.3.1