From 0b48f4a46d24248e4c012ef37d25b5963c27a78c Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sun, 23 Aug 2026 12:43:10 +0900 Subject: fix(fs): carry file_get_contents results as bytes file_get_contents() and file_get_contents_with_max_length() return Vec instead of a from_utf8_lossy'd String. Call sites whose consumer takes a &str still convert lossily and are marked TODO(bytes). file_get_contents_with_max_length() now reads at most the requested number of bytes instead of the whole file. Co-Authored-By: Claude Opus 5 (1M context) --- crates/shirabe/src/package/locker.rs | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'crates/shirabe/src/package') diff --git a/crates/shirabe/src/package/locker.rs b/crates/shirabe/src/package/locker.rs index b98b8dae..3af06ce3 100644 --- a/crates/shirabe/src/package/locker.rs +++ b/crates/shirabe/src/package/locker.rs @@ -631,10 +631,10 @@ impl Locker { Box) -> IndexMap>, >, ) -> anyhow::Result<()> { - let contents = file_get_contents(composer_json.get_path()); - let contents = match contents { - Some(s) => s, - None => { + let contents = match file_get_contents(composer_json.get_path()) { + // TODO(bytes): get_content_hash parses the contents as a &str. + Ok(s) => String::from_utf8_lossy(&s).into_owned(), + Err(_) => { return Err(RuntimeException::new(format!( "Unable to read {} contents to update the lock file hash.", composer_json.get_path() -- cgit v1.3.1-4-g156e