From 71b432db3f115d17be498f36cd3efd40b4650a0b Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sat, 6 Jun 2026 17:08:18 +0900 Subject: refactor(version-bumper): share caller's VersionParser with ArrayLoader Mirror PHP's "new ArrayLoader($parser)" by passing the existing parser instead of None. VersionParser is stateless, so behavior is unchanged; this drops the phase-b TODO. Co-Authored-By: Claude Opus 4.8 noreply@anthropic.com --- crates/shirabe/src/package/version/version_bumper.rs | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) (limited to 'crates/shirabe/src/package') diff --git a/crates/shirabe/src/package/version/version_bumper.rs b/crates/shirabe/src/package/version/version_bumper.rs index e54ad10..627a0fb 100644 --- a/crates/shirabe/src/package/version/version_bumper.rs +++ b/crates/shirabe/src/package/version/version_bumper.rs @@ -28,10 +28,7 @@ impl VersionBumper { let mut version = package.get_version().to_string(); if version.starts_with("dev-") { - // TODO(phase-b): ArrayLoader::new takes Option by value; pass None until - // VersionParser sharing is reconciled. - let _ = &parser; - let loader = ArrayLoader::new(None, false); + let loader = ArrayLoader::new(Some(parser.clone()), false); let dumper = ArrayDumper::new(); let dumped = dumper.dump(package.clone()); let extra = loader.get_branch_alias(&dumped)?; -- cgit v1.3.1