From 7e31bab9ff7209c9b6d7928a581d7a449846f42e Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sun, 2 Aug 2026 17:32:43 +0900 Subject: fix(json): propagate JsonFile::encode errors instead of unwrapping PHP's JsonFile::encode throws a RuntimeException when json_encode fails; the port swallowed that into an .unwrap() marked TODO(phase-c). Return anyhow::Result from encode/encode_with_options and propagate at every call site (print_table and list_repositories become Result-returning to carry it). Co-Authored-By: Claude Fable 5 --- crates/shirabe/src/package/locker.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'crates/shirabe/src/package') diff --git a/crates/shirabe/src/package/locker.rs b/crates/shirabe/src/package/locker.rs index 02cbfa4a..b7d8ba7a 100644 --- a/crates/shirabe/src/package/locker.rs +++ b/crates/shirabe/src/package/locker.rs @@ -132,7 +132,7 @@ impl Locker { &JsonFile::encode_with_options( &PhpMixed::Array(relevant_content.into_iter().collect()), JsonEncodeOptions::none(), - ), + )?, )) } @@ -620,7 +620,7 @@ impl Locker { let parsed = JsonFile::parse_json( Some(&JsonFile::encode(&PhpMixed::Array( lock.into_iter().collect(), - ))), + ))?), None, )?; let parsed_map: IndexMap = match parsed { -- cgit v1.3.1