From 1fdbfc1a277a788f8317ed47fccda22c587d3363 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sat, 4 Jul 2026 15:26:26 +0900 Subject: fix(pcre): restore missing regex delimiters in ported patterns Several Preg::*() call sites lost their PHP delimiter (and in one case the `i` modifier) during porting, since preg_*() expects the delimiter to be preserved in the caller's pattern literal and stripped internally. This made compile_php_pattern panic or silently misparse the pattern. Un-ignore the Version tests that were blocked by this bug. --- crates/shirabe/src/platform/version.rs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'crates/shirabe/src/platform/version.rs') diff --git a/crates/shirabe/src/platform/version.rs b/crates/shirabe/src/platform/version.rs index b78baad..cbbbe44 100644 --- a/crates/shirabe/src/platform/version.rs +++ b/crates/shirabe/src/platform/version.rs @@ -12,7 +12,7 @@ impl Version { let mut matches: IndexMap = IndexMap::new(); if !Preg::match3( - r"^(?P[0-9.]+)(?P[a-z]{0,2})(?P(?:-?(?:dev|pre|alpha|beta|rc|fips)[\d]*)*)(?:-\w+)?(?: \(.+?\))?$", + r"/^(?P[0-9.]+)(?P[a-z]{0,2})(?P(?:-?(?:dev|pre|alpha|beta|rc|fips)[\d]*)*)(?:-\w+)?(?: \(.+?\))?$/", openssl_version, Some(&mut matches), ) { @@ -56,7 +56,7 @@ impl Version { pub fn parse_libjpeg(libjpeg_version: &str) -> Option { let mut matches: IndexMap = IndexMap::new(); if !Preg::match3( - r"^(?P\d+)(?P[a-z]*)$", + r"/^(?P\d+)(?P[a-z]*)$/", libjpeg_version, Some(&mut matches), ) { @@ -81,7 +81,7 @@ impl Version { pub fn parse_zoneinfo_version(zoneinfo_version: &str) -> Option { let mut matches: IndexMap = IndexMap::new(); if !Preg::match3( - r"^(?P\d{4})(?P[a-z]*)$", + r"/^(?P\d{4})(?P[a-z]*)$/", zoneinfo_version, Some(&mut matches), ) { -- cgit v1.3.1