From 91692846909ed191addb7ec1c34aad11392ab88b Mon Sep 17 00:00:00 2001
From: nsfisis <nsfisis@gmail.com>
Date: Sat, 18 Jul 2026 15:03:55 +0900
Subject: perf(regex): eliminate per-call clone overhead in preg_* dispatch

regex::Regex::clone() does not share the underlying meta engine's
search-cache pool, so every fresh clone pays a ~10us warmup cost on
its first use. Two changes together eliminate this across nearly all
preg_* call sites:

- A php_regex! macro resolves PHP-style patterns to a per-call-site
  &'static regex::Regex (via regex-macro's LazyLock), applied at the
  majority of call sites throughout the codebase.
- Call sites still passing dynamic pattern strings go through
  PATTERN_CACHE, which now stores Arc<(Regex, bool)> and hands out
  Arc::clone()s instead of cloning the Regex itself.

PregPattern::resolve() returns a ResolvedPattern enum (Arc or
'static reference) rather than an owned Regex, so neither path ever
clones the Regex proper.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
---
 crates/shirabe/src/platform/version.rs | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

(limited to 'crates/shirabe/src/platform/version.rs')

diff --git a/crates/shirabe/src/platform/version.rs b/crates/shirabe/src/platform/version.rs
index cbbbe44e..feed1b85 100644
--- a/crates/shirabe/src/platform/version.rs
+++ b/crates/shirabe/src/platform/version.rs
@@ -2,7 +2,7 @@
 
 use indexmap::IndexMap;
 use shirabe_external_packages::composer::pcre::{CaptureKey, Preg};
-use shirabe_php_shim::version_compare;
+use shirabe_php_shim::{php_regex, version_compare};
 
 pub struct Version;
 
@@ -12,7 +12,9 @@ impl Version {
 
         let mut matches: IndexMap<CaptureKey, String> = IndexMap::new();
         if !Preg::match3(
-            r"/^(?P<version>[0-9.]+)(?P<patch>[a-z]{0,2})(?P<suffix>(?:-?(?:dev|pre|alpha|beta|rc|fips)[\d]*)*)(?:-\w+)?(?: \(.+?\))?$/",
+            php_regex!(
+                r"/^(?P<version>[0-9.]+)(?P<patch>[a-z]{0,2})(?P<suffix>(?:-?(?:dev|pre|alpha|beta|rc|fips)[\d]*)*)(?:-\w+)?(?: \(.+?\))?$/"
+            ),
             openssl_version,
             Some(&mut matches),
         ) {
@@ -56,7 +58,7 @@ impl Version {
     pub fn parse_libjpeg(libjpeg_version: &str) -> Option<String> {
         let mut matches: IndexMap<CaptureKey, String> = IndexMap::new();
         if !Preg::match3(
-            r"/^(?P<major>\d+)(?P<minor>[a-z]*)$/",
+            php_regex!(r"/^(?P<major>\d+)(?P<minor>[a-z]*)$/"),
             libjpeg_version,
             Some(&mut matches),
         ) {
@@ -81,7 +83,7 @@ impl Version {
     pub fn parse_zoneinfo_version(zoneinfo_version: &str) -> Option<String> {
         let mut matches: IndexMap<CaptureKey, String> = IndexMap::new();
         if !Preg::match3(
-            r"/^(?P<year>\d{4})(?P<revision>[a-z]*)$/",
+            php_regex!(r"/^(?P<year>\d{4})(?P<revision>[a-z]*)$/"),
             zoneinfo_version,
             Some(&mut matches),
         ) {
-- 
cgit v1.3.1