From 52a0665acbbe5bf5b8c6875118fb9cdf7952453b Mon Sep 17 00:00:00 2001 From: nsfisis Date: Mon, 17 Aug 2026 06:43:52 +0900 Subject: refactor(preg): wrap the preg_* $matches maps in newtypes The five IndexMap shapes that the preg_* functions and Preg fill in are now distinct types generated by preg_match_map!, so a matches map no longer interchanges with any other map of the same key and value type. Index is kept alongside Index<&Q> because call sites such as config_command and event_dispatcher reach for a group by its position in the map rather than by its capture key. --- crates/shirabe/src/platform/version.rs | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) (limited to 'crates/shirabe/src/platform') diff --git a/crates/shirabe/src/platform/version.rs b/crates/shirabe/src/platform/version.rs index b3eacd4c..2bcb4c38 100644 --- a/crates/shirabe/src/platform/version.rs +++ b/crates/shirabe/src/platform/version.rs @@ -1,7 +1,6 @@ //! ref: composer/src/Composer/Platform/Version.php -use indexmap::IndexMap; -use shirabe_pcre::{CaptureKey, Preg}; +use shirabe_pcre::{CaptureKey, Preg, PregMatchedGroups}; use shirabe_php_shim::{CmpOp, php_regex, version_compare}; pub struct Version; @@ -10,7 +9,7 @@ impl Version { pub fn parse_openssl(openssl_version: &str, is_fips: &mut bool) -> Option { *is_fips = false; - let mut matches: IndexMap = IndexMap::new(); + let mut matches = PregMatchedGroups::new(); if !Preg::match3( php_regex!( r"/^(?P[0-9.]+)(?P[a-z]{0,2})(?P(?:-?(?:dev|pre|alpha|beta|rc|fips)[\d]*)*)(?:-\w+)?(?: \(.+?\))?$/" @@ -56,7 +55,7 @@ impl Version { } pub fn parse_libjpeg(libjpeg_version: &str) -> Option { - let mut matches: IndexMap = IndexMap::new(); + let mut matches = PregMatchedGroups::new(); if !Preg::match3( php_regex!(r"/^(?P\d+)(?P[a-z]*)$/"), libjpeg_version, @@ -81,7 +80,7 @@ impl Version { } pub fn parse_zoneinfo_version(zoneinfo_version: &str) -> Option { - let mut matches: IndexMap = IndexMap::new(); + let mut matches = PregMatchedGroups::new(); if !Preg::match3( php_regex!(r"/^(?P\d{4})(?P[a-z]*)$/"), zoneinfo_version, -- cgit v1.3.1-4-g156e