From 7f810b1bb288445ee5376fada752e84ecb1ce211 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Wed, 24 Jun 2026 21:38:53 +0900 Subject: feat(process): wire execute output handling to a callback model Replace the Option<&mut PhpMixed> output plumbing with the IntoExecOutput trait modelling each PHP `$output` case (forward, capture-to-buffer, discard, callback). This lets do_execute pass a real output handler to Process::run, captures output back via get_output, and lets Svn pass its streaming filter handler through execute instead of skipping it. --- crates/shirabe/src/platform/hhvm_detector.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'crates/shirabe/src/platform') diff --git a/crates/shirabe/src/platform/hhvm_detector.rs b/crates/shirabe/src/platform/hhvm_detector.rs index 152e29a..da062d5 100644 --- a/crates/shirabe/src/platform/hhvm_detector.rs +++ b/crates/shirabe/src/platform/hhvm_detector.rs @@ -69,7 +69,7 @@ impl HhvmDetector { ); let exit_code = executor .borrow_mut() - .execute(cmd, Some(&mut version_output), None) + .execute(cmd, &mut version_output, None) .unwrap_or(1); if exit_code == 0 { *cache = Some(version_output.as_string().map(|s| s.to_string())); -- cgit v1.3.1