From 3a388b98a9aa6a14b1c7f7dc909c109cf9837800 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sun, 16 Aug 2026 00:59:54 +0900 Subject: refactor: narrow pub(crate) items to private Porting mapped every PHP `protected` member onto `pub(crate)`, which is wider than nearly all of them need. Each item demoted here is reached only from the module that defines it, so the crate-wide visibility conveyed nothing. Every `pub(crate)` that survives has at least one reader in another module of the same crate. Co-Authored-By: Claude Opus 5 (1M context) --- crates/shirabe/src/plugin/php_plugin_proxy.rs | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) (limited to 'crates/shirabe/src/plugin/php_plugin_proxy.rs') diff --git a/crates/shirabe/src/plugin/php_plugin_proxy.rs b/crates/shirabe/src/plugin/php_plugin_proxy.rs index 9a93ef72..967faa1b 100644 --- a/crates/shirabe/src/plugin/php_plugin_proxy.rs +++ b/crates/shirabe/src/plugin/php_plugin_proxy.rs @@ -190,9 +190,7 @@ fn operation_stub_class(operation: &AnyOperation) -> &'static str { } /// Registers a package and returns its wire descriptor. -pub(crate) fn package_handle_value( - package: &std::rc::Rc>, -) -> PluginValue { +fn package_handle_value(package: &std::rc::Rc>) -> PluginValue { let class = package_stub_class(package); let rhandle = register_entity(RustEntity::Package(package.clone())); rust_handle_value(rhandle, class) @@ -2442,11 +2440,11 @@ pub(crate) fn repository_handle_value( /// `composer-installer` package names. Every call is forwarded as a `CallPhpMethod` RPC. #[derive(Debug)] pub struct PhpInstallerProxy { - pub(crate) handle: PhpObjHandle, + handle: PhpObjHandle, } impl PhpInstallerProxy { - pub(crate) fn new(handle: PhpObjHandle) -> Self { + fn new(handle: PhpObjHandle) -> Self { Self { handle } } @@ -2674,7 +2672,7 @@ fn forget_php_installer_proxy(phandle: u64) { /// `Composer\Plugin\Capability\Capability` marker). #[derive(Debug)] pub struct PhpCapabilityProxy { - pub(crate) handle: PhpObjHandle, + handle: PhpObjHandle, } impl PhpCapabilityProxy { @@ -2831,7 +2829,7 @@ impl RustCommandMetadata { /// `Application::register_worker_console_commands` as worker-hosted commands are registered, /// booted in the worker the first time one of them actually runs. #[derive(Debug)] -pub(crate) struct PhpConsoleApplicationContext { +struct PhpConsoleApplicationContext { composer: Option, io: std::rc::Rc>, initial_working_directory: Option, @@ -2995,7 +2993,7 @@ pub struct PhpCommandProxy { } impl PhpCommandProxy { - pub(crate) fn new(handle: PhpObjHandle) -> anyhow::Result { + fn new(handle: PhpObjHandle) -> anyhow::Result { let proxy_command = match Self::call_metadata_getter(&handle, "isProxyCommand")? { PluginValue::Bool(proxy_command) => proxy_command, other => return Err(Self::unsupported_shape(&handle, "isProxyCommand", &other)), -- cgit v1.3.1-4-g156e