From 3a388b98a9aa6a14b1c7f7dc909c109cf9837800 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sun, 16 Aug 2026 00:59:54 +0900 Subject: refactor: narrow pub(crate) items to private Porting mapped every PHP `protected` member onto `pub(crate)`, which is wider than nearly all of them need. Each item demoted here is reached only from the module that defines it, so the crate-wide visibility conveyed nothing. Every `pub(crate)` that survives has at least one reader in another module of the same crate. Co-Authored-By: Claude Opus 5 (1M context) --- crates/shirabe/src/plugin/plugin_manager.rs | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) (limited to 'crates/shirabe/src/plugin/plugin_manager.rs') diff --git a/crates/shirabe/src/plugin/plugin_manager.rs b/crates/shirabe/src/plugin/plugin_manager.rs index 9f569af7..b02a702d 100644 --- a/crates/shirabe/src/plugin/plugin_manager.rs +++ b/crates/shirabe/src/plugin/plugin_manager.rs @@ -36,15 +36,15 @@ use shirabe_semver::constraint::SimpleConstraint; #[derive(Debug)] pub struct PluginManager { - pub(crate) composer: ComposerWeakHandle, - pub(crate) io: std::rc::Rc>, - pub(crate) global_composer: Option, - pub(crate) version_parser: VersionParser, - pub(crate) disable_plugins: DisablePlugins, + composer: ComposerWeakHandle, + io: std::rc::Rc>, + global_composer: Option, + version_parser: VersionParser, + disable_plugins: DisablePlugins, // PHP stores the same plugin instance in both $plugins and $registeredPlugins (reference // semantics); shared handles preserve the identity comparisons that relies on. - pub(crate) plugins: Vec>>, - pub(crate) registered_plugins: IndexMap>, + plugins: Vec>>, + registered_plugins: IndexMap>, allow_plugin_rules: Option>, allow_global_plugin_rules: Option>, running_in_global_dir: bool, @@ -696,7 +696,7 @@ impl PluginManager { } /// Returns the version of the internal composer-plugin-api package. - pub(crate) fn get_plugin_api_version(&self) -> String { + fn get_plugin_api_version(&self) -> String { match &self.plugin_api_version_override { Some(version) => version.clone(), None => plugin_interface::PLUGIN_API_VERSION.to_string(), @@ -996,7 +996,7 @@ impl PluginManager { .get_install_path(package) } - pub(crate) fn get_capability_implementation_class_name( + fn get_capability_implementation_class_name( &self, plugin: &dyn PluginInterface, capability: &str, -- cgit v1.3.1-4-g156e