From 971824aa15334fd12d08ae0f441f6bf6079344c3 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sun, 7 Jun 2026 10:33:53 +0900 Subject: feat(shirabe): resolve phase-b TODOs with shared ownership Replace TODO(phase-b) placeholders (todo!() and commented-out code) with real implementations: - Share JsonFile via Rc> so JsonConfigSource and the owning command can hold the same instance (base_config_command, config_command, repository_command, require_command, create_project, remove_command, factory) - Change InstallerInterface methods (is_installed, download, prepare, cleanup, get_install_path) to &mut self so initialize_vendor_dir can run, propagated to all installer implementations - Pass io/config/filesystem/process by clone instead of moving or stubbing (auth_helper, svn_driver, curl_downloader, library_installer) - Make TransportException Clone and store it by value in VcsRepository - Clone operations in Transaction sort, root_aliases/temporary_constraints in RepositorySet::create_pool, and share CompletePackage via handle in PlatformRepository - Wire up set_option, set_requires/set_dev_requires, installation manager setters, BumpCommand::set_composer, and clean_backups/set_local_phar --- crates/shirabe/src/plugin/plugin_manager.rs | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) (limited to 'crates/shirabe/src/plugin') diff --git a/crates/shirabe/src/plugin/plugin_manager.rs b/crates/shirabe/src/plugin/plugin_manager.rs index d4c3113..9dcf754 100644 --- a/crates/shirabe/src/plugin/plugin_manager.rs +++ b/crates/shirabe/src/plugin/plugin_manager.rs @@ -126,19 +126,17 @@ impl PluginManager { pub fn load_installed_plugins(&mut self) -> anyhow::Result<()> { // TODO(plugin): plugin loading is part of the plugin API if !self.are_plugins_disabled("local") { - // TODO(phase-b): PHP returns a shared object reference; we clone the repository - // box here to side-step a borrow conflict between `&self.composer` and - // `&mut self`. The Rust port should eventually share via Rc>. let repo = self .composer_full() .borrow() .get_repository_manager() .borrow() .get_local_repository(); - let root_package = crate::package::RootPackageInterfaceHandle::dup( - self.composer_full().borrow().get_package(), - ); - self.load_repository(&mut *repo.borrow_mut(), false, Some(root_package))?; + self.load_repository( + &mut *repo.borrow_mut(), + false, + Some(self.composer_full().borrow().get_package().clone()), + )?; } if self.global_composer.is_some() && !self.are_plugins_disabled("global") { -- cgit v1.3.1