From cd25c3e193f05a5e89bca2a1c706c85fdc9c9155 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sat, 6 Jun 2026 02:13:59 +0900 Subject: refactor(repository): make read methods fallible and take &mut self Change RepositoryInterface and WritableRepositoryInterface read methods (find_package, find_packages, get_packages, load_packages, search, get_providers, get_canonical_packages) to take &mut self and return anyhow::Result, so lazy-loading repositories such as ComposerRepository can perform fallible I/O and mutate internal state on access. Update all implementors and call sites to propagate the Result and pass mutable references. Co-Authored-By: Claude Opus 4.8 (1M context) --- crates/shirabe/src/repository/canonical_packages_trait.rs | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) (limited to 'crates/shirabe/src/repository/canonical_packages_trait.rs') diff --git a/crates/shirabe/src/repository/canonical_packages_trait.rs b/crates/shirabe/src/repository/canonical_packages_trait.rs index 5f0ecff..11088aa 100644 --- a/crates/shirabe/src/repository/canonical_packages_trait.rs +++ b/crates/shirabe/src/repository/canonical_packages_trait.rs @@ -1,15 +1,14 @@ //! ref: composer/src/Composer/Repository/CanonicalPackagesTrait.php use crate::package::PackageInterfaceHandle; +use crate::repository::RepositoryInterface; use indexmap::IndexMap; /// Provides get_canonical_packages() to various repository implementations. -pub trait CanonicalPackagesTrait { - fn get_packages(&self) -> Vec; - +pub trait CanonicalPackagesTrait: RepositoryInterface { /// Get unique packages (at most one package of each name), with aliases resolved and removed. - fn get_canonical_packages(&self) -> Vec { - let packages = self.get_packages(); + fn get_canonical_packages(&mut self) -> anyhow::Result> { + let packages = self.get_packages()?; // get at most one package of each name, preferring non-aliased ones let mut packages_by_name: IndexMap = IndexMap::new(); @@ -34,6 +33,6 @@ pub trait CanonicalPackagesTrait { canonical_packages.push(package); } - canonical_packages + Ok(canonical_packages) } } -- cgit v1.3.1