From af4b9fcba1206e3fcc97fc243ffc674f85547942 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sat, 6 Jun 2026 19:47:36 +0900 Subject: refactor(http-response): take url directly instead of request map Response only ever reads the url out of the request array, so accept it as a String directly. With url always present the 'url key missing' LogicException can no longer fire, so Response::new and CurlResponse::new return Self instead of a double Result. Also drops the unused from_php_mixed/to_php_mixed stubs and the request_to_map helper. Co-Authored-By: Claude Opus 4.8 (1M context) --- crates/shirabe/src/repository/composer_repository.rs | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 'crates/shirabe/src/repository/composer_repository.rs') diff --git a/crates/shirabe/src/repository/composer_repository.rs b/crates/shirabe/src/repository/composer_repository.rs index 74f1426..0d2fa2f 100644 --- a/crates/shirabe/src/repository/composer_repository.rs +++ b/crates/shirabe/src/repository/composer_repository.rs @@ -3253,14 +3253,15 @@ impl ComposerRepository { // if the file is in the cache, we fake a 304 Not Modified to allow the process to continue if last_modified_time.is_some() { - let resp = Response::new_fake(&self.url, 304, IndexMap::new(), String::new()); + let resp = Response::new(self.url.clone(), Some(304), Vec::new(), Some(String::new())); return self.async_fetch_file_accept(resp, filename, cache_key); } // special error code returned when network is being artificially disabled if let Some(te) = e.downcast_ref::() { if te.get_status_code() == Some(499) { - let resp = Response::new_fake(&self.url, 404, IndexMap::new(), String::new()); + let resp = + Response::new(self.url.clone(), Some(404), Vec::new(), Some(String::new())); return self.async_fetch_file_accept(resp, filename, cache_key); } } -- cgit v1.3.1