From cc5d73c05a0abca2eebcc8a6afa0b1543ee49850 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Wed, 27 May 2026 00:49:33 +0900 Subject: refactor(package): pass package handles by value throughout Co-Authored-By: Claude Opus 4.7 (1M context) --- crates/shirabe/src/repository/composite_repository.rs | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) (limited to 'crates/shirabe/src/repository/composite_repository.rs') diff --git a/crates/shirabe/src/repository/composite_repository.rs b/crates/shirabe/src/repository/composite_repository.rs index 024f89a..12f1837 100644 --- a/crates/shirabe/src/repository/composite_repository.rs +++ b/crates/shirabe/src/repository/composite_repository.rs @@ -6,7 +6,6 @@ use indexmap::IndexMap; use shirabe_semver::constraint::AnyConstraint; use crate::package::BasePackageHandle; -use crate::package::PackageInterface; use crate::package::PackageInterfaceHandle; use crate::repository::{ FindPackageConstraint, LoadPackagesResult, ProviderInfo, RepositoryInterface, SearchResult, @@ -32,7 +31,7 @@ impl CompositeRepository { &self.repositories } - pub fn remove_package(&mut self, _package: &dyn PackageInterface) { + pub fn remove_package(&mut self, _package: PackageInterfaceHandle) { // TODO(phase-b): only call remove_package on WritableRepositoryInterface implementors; // requires a downcast helper such as `as_writable() -> Option<&mut dyn WritableRepositoryInterface>` on RepositoryInterface. for _repository in &mut self.repositories { @@ -67,9 +66,9 @@ impl RepositoryInterface for CompositeRepository { format!("composite repo ({})", names.join(", ")) } - fn has_package(&self, package: &dyn PackageInterface) -> bool { + fn has_package(&self, package: PackageInterfaceHandle) -> bool { for repository in &self.repositories { - if repository.has_package(package) { + if repository.has_package(package.clone()) { return true; } } -- cgit v1.3.1