From 1e7aabcae1b2139aa20a80fbf303c74388933f55 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sat, 6 Jun 2026 15:16:07 +0900 Subject: fix(array-dumper): emit package links and require Link pretty constraint Resolve the phase-b TODO that left the supported-link-types loop as dead code (links were always an empty Vec), so requires/conflicts/provides/ replaces/require-dev are dumped again via PackageInterface::get_links_for_type, matching the PHP magic-call loop. Every Link in production is constructed with a pretty constraint (all ArrayLoader/AliasPackage/PlatformRepository/InstalledRepository sites pass one), so make Link::pretty_constraint a required String instead of Option. get_pretty_constraint() now returns &str directly rather than anyhow::Result<&str>, dropping the unreachable UnexpectedValueException guard, and all call sites are updated. Co-Authored-By: Claude Opus 4.8 --- crates/shirabe/src/repository/filesystem_repository.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'crates/shirabe/src/repository/filesystem_repository.rs') diff --git a/crates/shirabe/src/repository/filesystem_repository.rs b/crates/shirabe/src/repository/filesystem_repository.rs index c373bd9..d9d3289 100644 --- a/crates/shirabe/src/repository/filesystem_repository.rs +++ b/crates/shirabe/src/repository/filesystem_repository.rs @@ -559,7 +559,7 @@ impl FilesystemRepository { todo!("mutate nested versions['versions'][target]['dev_requirement']"); #[allow(unreachable_code)] { - let mut replaced = replace.get_pretty_constraint().unwrap_or("").to_string(); + let mut replaced = replace.get_pretty_constraint().to_string(); if replaced == "self.version" { replaced = package.get_pretty_version().to_string(); } @@ -576,7 +576,7 @@ impl FilesystemRepository { todo!("mutate nested versions['versions'][target]['dev_requirement']"); #[allow(unreachable_code)] { - let mut provided = provide.get_pretty_constraint().unwrap_or("").to_string(); + let mut provided = provide.get_pretty_constraint().to_string(); if provided == "self.version" { provided = package.get_pretty_version().to_string(); } -- cgit v1.3.1