From 5ab5f3b316798c1411ce8e6a7f5b091fda93589c Mon Sep 17 00:00:00 2001 From: nsfisis Date: Mon, 22 Jun 2026 23:42:07 +0900 Subject: test: port previously-ignored Composer tests via __ test hatches Re-evaluate the reason'd #[ignore] tests under the Phase D criterion: a test is unportable ONLY if the APIs/types needed to WRITE it do not exist. A test that compiles but panics at runtime (todo!() body, a regex the regex crate cannot compile) or fails at runtime (incomplete or incorrect impl behavior) is portable -- it is written in full and marked with a reason-less #[ignore]. About 120 test functions move from reason'd #[ignore] to reason-less #[ignore] (the ported-but-not-yet-passing signal). Impl crates gain only additive __ test hatches (init_command, pool, file_downloader, package handle link setters, artifact/path repository, repository manager, svn); no existing logic changes. Tests whose required APIs genuinely do not exist (mock/reflection harness, ApplicationTester, solve() discarding SolverProblemsException, a script::Event that cannot be passed as an originating event) keep their reason'd #[ignore]. cargo check -p shirabe --tests passes. Co-Authored-By: Claude Opus 4.8 (1M context) --- crates/shirabe/src/repository/path_repository.rs | 26 ++++++++++++++++++++++++ 1 file changed, 26 insertions(+) (limited to 'crates/shirabe/src/repository/path_repository.rs') diff --git a/crates/shirabe/src/repository/path_repository.rs b/crates/shirabe/src/repository/path_repository.rs index 4508460..b8c106a 100644 --- a/crates/shirabe/src/repository/path_repository.rs +++ b/crates/shirabe/src/repository/path_repository.rs @@ -113,6 +113,32 @@ impl PathRepository { ) } + /// For testing only: drives `initialize` (globbing the configured url and loading each + /// path package) and returns the packages collected by the inner `ArrayRepository`, + /// mirroring the polymorphic `RepositoryInterface::getPackages` dispatch in PHP. + pub fn __get_packages(&mut self) -> anyhow::Result> { + self.initialize()?; + use crate::repository::RepositoryInterface; + self.inner.get_packages() + } + + /// For testing only: returns `RepositoryInterface::count` after `initialize`. + pub fn __count(&mut self) -> anyhow::Result { + self.initialize()?; + use crate::repository::RepositoryInterface; + self.inner.count() + } + + /// For testing only: returns `RepositoryInterface::has_package` after `initialize`. + pub fn __has_package( + &mut self, + package: crate::package::PackageInterfaceHandle, + ) -> anyhow::Result { + self.initialize()?; + use crate::repository::RepositoryInterface; + Ok(self.inner.has_package(package)) + } + pub(crate) fn initialize(&mut self) -> anyhow::Result<()> { self.inner.initialize(); -- cgit v1.3.1