From cd25c3e193f05a5e89bca2a1c706c85fdc9c9155 Mon Sep 17 00:00:00 2001
From: nsfisis <nsfisis@gmail.com>
Date: Sat, 6 Jun 2026 02:13:59 +0900
Subject: refactor(repository): make read methods fallible and take &mut self

Change RepositoryInterface and WritableRepositoryInterface read methods
(find_package, find_packages, get_packages, load_packages, search,
get_providers, get_canonical_packages) to take &mut self and return
anyhow::Result, so lazy-loading repositories such as ComposerRepository
can perform fallible I/O and mutate internal state on access. Update all
implementors and call sites to propagate the Result and pass mutable
references.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
---
 .../shirabe/src/repository/platform_repository.rs  | 30 +++++++++++-----------
 1 file changed, 15 insertions(+), 15 deletions(-)

(limited to 'crates/shirabe/src/repository/platform_repository.rs')

diff --git a/crates/shirabe/src/repository/platform_repository.rs b/crates/shirabe/src/repository/platform_repository.rs
index 0d10e3a..957e335 100644
--- a/crates/shirabe/src/repository/platform_repository.rs
+++ b/crates/shirabe/src/repository/platform_repository.rs
@@ -1615,7 +1615,7 @@ impl PlatformRepository {
             let overrider = self.inner.find_package(
                 &name,
                 crate::repository::FindPackageConstraint::String("*".to_string()),
-            );
+            )?;
             let actual_text = if let Some(ref ov) = overrider {
                 if package.get_version() == ov.get_version() {
                     "same as actual".to_string()
@@ -1888,14 +1888,14 @@ impl PlatformRepository {
     }
 
     pub fn search(
-        &self,
+        &mut self,
         query: String,
         mode: i64,
         r#type: Option<String>,
-    ) -> Vec<crate::repository::SearchResult> {
+    ) -> anyhow::Result<Vec<crate::repository::SearchResult>> {
         // suppress vendor search as there are no vendors to match in platform packages
         if mode == crate::repository::SEARCH_VENDOR {
-            return Vec::new();
+            return Ok(Vec::new());
         }
 
         self.inner.search(query, mode, r#type)
@@ -1954,32 +1954,32 @@ impl crate::repository::RepositoryInterface for PlatformRepository {
     }
 
     fn find_package(
-        &self,
+        &mut self,
         name: &str,
         constraint: crate::repository::FindPackageConstraint,
-    ) -> Option<crate::package::BasePackageHandle> {
+    ) -> anyhow::Result<Option<crate::package::BasePackageHandle>> {
         self.inner.find_package(name, constraint)
     }
 
     fn find_packages(
-        &self,
+        &mut self,
         name: &str,
         constraint: Option<crate::repository::FindPackageConstraint>,
-    ) -> Vec<crate::package::BasePackageHandle> {
+    ) -> anyhow::Result<Vec<crate::package::BasePackageHandle>> {
         self.inner.find_packages(name, constraint)
     }
 
-    fn get_packages(&self) -> Vec<crate::package::BasePackageHandle> {
+    fn get_packages(&mut self) -> anyhow::Result<Vec<crate::package::BasePackageHandle>> {
         self.inner.get_packages()
     }
 
     fn load_packages(
-        &self,
+        &mut self,
         package_name_map: IndexMap<String, Option<shirabe_semver::constraint::AnyConstraint>>,
         acceptable_stabilities: IndexMap<String, i64>,
         stability_flags: IndexMap<String, i64>,
         already_loaded: IndexMap<String, IndexMap<String, crate::package::PackageInterfaceHandle>>,
-    ) -> crate::repository::LoadPackagesResult {
+    ) -> anyhow::Result<crate::repository::LoadPackagesResult> {
         self.inner.load_packages(
             package_name_map,
             acceptable_stabilities,
@@ -1989,18 +1989,18 @@ impl crate::repository::RepositoryInterface for PlatformRepository {
     }
 
     fn search(
-        &self,
+        &mut self,
         query: String,
         mode: i64,
         r#type: Option<String>,
-    ) -> Vec<crate::repository::SearchResult> {
+    ) -> anyhow::Result<Vec<crate::repository::SearchResult>> {
         self.inner.search(query, mode, r#type)
     }
 
     fn get_providers(
-        &self,
+        &mut self,
         package_name: String,
-    ) -> IndexMap<String, crate::repository::ProviderInfo> {
+    ) -> anyhow::Result<IndexMap<String, crate::repository::ProviderInfo>> {
         self.inner.get_providers(package_name)
     }
 
-- 
cgit v1.3.1