From efe5bdb1987411a473d4af15451a376d20928245 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Fri, 12 Jun 2026 03:19:34 +0900 Subject: refactor(php-shim): replace literal sprintf calls with format! Convert every sprintf() call with a compile-time literal format string to format!, implementing Display for PhpMixed (delegating to php_to_string) so PhpMixed values render with PHP string semantics through {}. Also merge the format!-wrapped and conditional-literal dynamic sites into single format! calls. Genuinely runtime format strings (table styles, configurable error messages, command synopsis, progress-bar modifiers, regex-built messages) still go through sprintf. Co-Authored-By: Claude Opus 4.8 (1M context) --- crates/shirabe/src/repository/platform_repository.rs | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) (limited to 'crates/shirabe/src/repository/platform_repository.rs') diff --git a/crates/shirabe/src/repository/platform_repository.rs b/crates/shirabe/src/repository/platform_repository.rs index 932584c..d9954af 100644 --- a/crates/shirabe/src/repository/platform_repository.rs +++ b/crates/shirabe/src/repository/platform_repository.rs @@ -1342,13 +1342,11 @@ impl PlatformRepository { .get_constant("RD_KAFKA_VERSION", None) .as_int() .unwrap_or(0); - let version_built = sprintf( - "%d.%d.%d", - &[ - PhpMixed::Int((lib_rd_kafka_version_int & 0x7F000000) >> 24), - PhpMixed::Int((lib_rd_kafka_version_int & 0x00FF0000) >> 16), - PhpMixed::Int((lib_rd_kafka_version_int & 0x0000FF00) >> 8), - ], + let version_built = format!( + "{}.{}.{}", + PhpMixed::Int((lib_rd_kafka_version_int & 0x7F000000) >> 24), + PhpMixed::Int((lib_rd_kafka_version_int & 0x00FF0000) >> 16), + PhpMixed::Int((lib_rd_kafka_version_int & 0x0000FF00) >> 8), ); self.add_library( &mut libraries, -- cgit v1.3.1