From cd25c3e193f05a5e89bca2a1c706c85fdc9c9155 Mon Sep 17 00:00:00 2001
From: nsfisis <nsfisis@gmail.com>
Date: Sat, 6 Jun 2026 02:13:59 +0900
Subject: refactor(repository): make read methods fallible and take &mut self

Change RepositoryInterface and WritableRepositoryInterface read methods
(find_package, find_packages, get_packages, load_packages, search,
get_providers, get_canonical_packages) to take &mut self and return
anyhow::Result, so lazy-loading repositories such as ComposerRepository
can perform fallible I/O and mutate internal state on access. Update all
implementors and call sites to propagate the Result and pass mutable
references.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
---
 .../shirabe/src/repository/repository_interface.rs | 30 +++++++++++++++-------
 1 file changed, 21 insertions(+), 9 deletions(-)

(limited to 'crates/shirabe/src/repository/repository_interface.rs')

diff --git a/crates/shirabe/src/repository/repository_interface.rs b/crates/shirabe/src/repository/repository_interface.rs
index e75f54e..249bd85 100644
--- a/crates/shirabe/src/repository/repository_interface.rs
+++ b/crates/shirabe/src/repository/repository_interface.rs
@@ -56,30 +56,38 @@ pub trait RepositoryInterface: Countable + std::fmt::Debug {
     fn has_package(&self, package: PackageInterfaceHandle) -> bool;
 
     fn find_package(
-        &self,
+        &mut self,
         name: &str,
         constraint: FindPackageConstraint,
-    ) -> Option<BasePackageHandle>;
+    ) -> anyhow::Result<Option<BasePackageHandle>>;
 
     fn find_packages(
-        &self,
+        &mut self,
         name: &str,
         constraint: Option<FindPackageConstraint>,
-    ) -> Vec<BasePackageHandle>;
+    ) -> anyhow::Result<Vec<BasePackageHandle>>;
 
-    fn get_packages(&self) -> Vec<BasePackageHandle>;
+    fn get_packages(&mut self) -> anyhow::Result<Vec<BasePackageHandle>>;
 
     fn load_packages(
-        &self,
+        &mut self,
         package_name_map: IndexMap<String, Option<AnyConstraint>>,
         acceptable_stabilities: IndexMap<String, i64>,
         stability_flags: IndexMap<String, i64>,
         already_loaded: IndexMap<String, IndexMap<String, PackageInterfaceHandle>>,
-    ) -> LoadPackagesResult;
+    ) -> anyhow::Result<LoadPackagesResult>;
 
-    fn search(&self, query: String, mode: i64, r#type: Option<String>) -> Vec<SearchResult>;
+    fn search(
+        &mut self,
+        query: String,
+        mode: i64,
+        r#type: Option<String>,
+    ) -> anyhow::Result<Vec<SearchResult>>;
 
-    fn get_providers(&self, package_name: String) -> IndexMap<String, ProviderInfo>;
+    fn get_providers(
+        &mut self,
+        package_name: String,
+    ) -> anyhow::Result<IndexMap<String, ProviderInfo>>;
 
     fn get_repo_name(&self) -> String;
 
@@ -87,6 +95,10 @@ pub trait RepositoryInterface: Countable + std::fmt::Debug {
         None
     }
 
+    fn as_advisory_provider_mut(&mut self) -> Option<&mut dyn AdvisoryProviderInterface> {
+        None
+    }
+
     fn as_installed_repository_interface(
         &self,
     ) -> Option<&dyn crate::repository::InstalledRepositoryInterface> {
-- 
cgit v1.3.1