From 1921f173ea219cb4b25847294d2d3fa465550fbb Mon Sep 17 00:00:00 2001 From: nsfisis Date: Mon, 25 May 2026 00:58:20 +0900 Subject: refactor(package): introduce Rc> handles for packages PHP packages have reference semantics, so introduce shared-ownership handles over an AnyPackage enum (PackageInterfaceHandle and friends) and replace Box throughout. Co-Authored-By: Claude Opus 4.7 (1M context) --- crates/shirabe/src/repository/repository_manager.rs | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) (limited to 'crates/shirabe/src/repository/repository_manager.rs') diff --git a/crates/shirabe/src/repository/repository_manager.rs b/crates/shirabe/src/repository/repository_manager.rs index e85312a..f432d6e 100644 --- a/crates/shirabe/src/repository/repository_manager.rs +++ b/crates/shirabe/src/repository/repository_manager.rs @@ -7,7 +7,7 @@ use shirabe_semver::constraint::AnyConstraint; use crate::config::Config; use crate::event_dispatcher::EventDispatcher; use crate::io::IOInterface; -use crate::package::PackageInterface; +use crate::package::PackageInterfaceHandle; use crate::repository::FilterRepository; use crate::repository::InstalledRepositoryInterface; use crate::repository::RepositoryInterface; @@ -52,13 +52,13 @@ impl RepositoryManager { &self, name: &str, constraint: &AnyConstraint, - ) -> Option> { + ) -> Option { for repository in &self.repositories { if let Some(package) = repository.find_package( name, crate::repository::FindPackageConstraint::Constraint(constraint.clone()), ) { - return Some(package.clone_package_box()); + return Some(package.clone().into()); } } None @@ -68,8 +68,8 @@ impl RepositoryManager { &self, name: &str, constraint: &AnyConstraint, - ) -> Vec> { - let mut packages: Vec> = vec![]; + ) -> Vec { + let mut packages: Vec = vec![]; for repository in self.get_repositories() { for p in repository.find_packages( name, @@ -77,7 +77,7 @@ impl RepositoryManager { constraint.clone(), )), ) { - packages.push(p.clone_package_box()); + packages.push(p.clone().into()); } } packages -- cgit v1.3.1