From 901878ee3f2bee6605b02d321cc4c92bc32fd5b0 Mon Sep 17 00:00:00 2001
From: nsfisis <nsfisis@gmail.com>
Date: Sat, 27 Jun 2026 08:44:57 +0900
Subject: refactor(composer): hold managers behind *Interface traits

Composer/PartialComposer exposed its RepositoryManager, InstallationManager,
EventDispatcher, Locker, DownloadManager, AutoloadGenerator and ArchiveManager
as concrete types, but Composer's public setters (setDownloadManager() etc.)
let plugins swap in subclasses. Introduce a *Interface trait per manager and
store each as Rc<RefCell<dyn ...Interface>> so a replacement is honored.

Only Composer's slots and the sinks fed from its accessors become trait
objects; managers injected concretely at construction keep their concrete
references, matching PHP semantics. Fluent setters on the affected classes now
return () and Locker::update_hash is de-generified to a boxed FnOnce so the
traits stay object-safe.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
---
 .../shirabe/src/repository/repository_manager.rs   | 43 ++++++++++++++++++++++
 1 file changed, 43 insertions(+)

(limited to 'crates/shirabe/src/repository/repository_manager.rs')

diff --git a/crates/shirabe/src/repository/repository_manager.rs b/crates/shirabe/src/repository/repository_manager.rs
index 247236c..41f4e7d 100644
--- a/crates/shirabe/src/repository/repository_manager.rs
+++ b/crates/shirabe/src/repository/repository_manager.rs
@@ -196,3 +196,46 @@ impl RepositoryManager {
         self.local_repository.clone().unwrap()
     }
 }
+
+// Composer's PartialComposer::setRepositoryManager() accepts any RepositoryManager subclass, so
+// plugins may swap in a replacement. The interface captures the methods reached through Composer's
+// accessor and through the `&mut RepositoryManager` parameters fed from it.
+pub trait RepositoryManagerInterface: std::fmt::Debug {
+    fn get_local_repository(&self) -> RepositoryInterfaceHandle;
+    fn get_repositories(&self) -> &Vec<RepositoryInterfaceHandle>;
+    fn create_repository(
+        &self,
+        r#type: &str,
+        config: IndexMap<String, PhpMixed>,
+        name: Option<&str>,
+    ) -> anyhow::Result<RepositoryInterfaceHandle>;
+    fn add_repository(&mut self, repository: RepositoryInterfaceHandle);
+    fn set_local_repository(&mut self, repository: RepositoryInterfaceHandle);
+}
+
+impl RepositoryManagerInterface for RepositoryManager {
+    fn get_local_repository(&self) -> RepositoryInterfaceHandle {
+        self.get_local_repository()
+    }
+
+    fn get_repositories(&self) -> &Vec<RepositoryInterfaceHandle> {
+        self.get_repositories()
+    }
+
+    fn create_repository(
+        &self,
+        r#type: &str,
+        config: IndexMap<String, PhpMixed>,
+        name: Option<&str>,
+    ) -> anyhow::Result<RepositoryInterfaceHandle> {
+        self.create_repository(r#type, config, name)
+    }
+
+    fn add_repository(&mut self, repository: RepositoryInterfaceHandle) {
+        self.add_repository(repository);
+    }
+
+    fn set_local_repository(&mut self, repository: RepositoryInterfaceHandle) {
+        self.set_local_repository(repository);
+    }
+}
-- 
cgit v1.3.1