From cd25c3e193f05a5e89bca2a1c706c85fdc9c9155 Mon Sep 17 00:00:00 2001
From: nsfisis <nsfisis@gmail.com>
Date: Sat, 6 Jun 2026 02:13:59 +0900
Subject: refactor(repository): make read methods fallible and take &mut self

Change RepositoryInterface and WritableRepositoryInterface read methods
(find_package, find_packages, get_packages, load_packages, search,
get_providers, get_canonical_packages) to take &mut self and return
anyhow::Result, so lazy-loading repositories such as ComposerRepository
can perform fallible I/O and mutate internal state on access. Update all
implementors and call sites to propagate the Result and pass mutable
references.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
---
 crates/shirabe/src/repository/repository_manager.rs | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

(limited to 'crates/shirabe/src/repository/repository_manager.rs')

diff --git a/crates/shirabe/src/repository/repository_manager.rs b/crates/shirabe/src/repository/repository_manager.rs
index dd69731..9b1d9ab 100644
--- a/crates/shirabe/src/repository/repository_manager.rs
+++ b/crates/shirabe/src/repository/repository_manager.rs
@@ -55,23 +55,23 @@ impl RepositoryManager {
         &self,
         name: &str,
         constraint: &AnyConstraint,
-    ) -> Option<PackageInterfaceHandle> {
+    ) -> anyhow::Result<Option<PackageInterfaceHandle>> {
         for repository in &self.repositories {
             if let Some(package) = repository.find_package(
                 name,
                 crate::repository::FindPackageConstraint::Constraint(constraint.clone()),
-            ) {
-                return Some(package.into());
+            )? {
+                return Ok(Some(package.into()));
             }
         }
-        None
+        Ok(None)
     }
 
     pub fn find_packages(
         &self,
         name: &str,
         constraint: &AnyConstraint,
-    ) -> Vec<PackageInterfaceHandle> {
+    ) -> anyhow::Result<Vec<PackageInterfaceHandle>> {
         let mut packages: Vec<PackageInterfaceHandle> = vec![];
         for repository in self.get_repositories() {
             for p in repository.find_packages(
@@ -79,11 +79,11 @@ impl RepositoryManager {
                 Some(crate::repository::FindPackageConstraint::Constraint(
                     constraint.clone(),
                 )),
-            ) {
+            )? {
                 packages.push(p);
             }
         }
-        packages
+        Ok(packages)
     }
 
     pub fn add_repository(&mut self, repository: RepositoryInterfaceHandle) {
-- 
cgit v1.3.1