From cd7c3fce2472656b2a1247429751e43350976677 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Wed, 19 Aug 2026 23:45:38 +0900 Subject: perf(package): hand out link maps behind Rc PackageInterface::getRequires() and friends return the array of Link objects; in PHP that is a copy-on-write array of object references, so a caller pays nothing to look at it. The port returned IndexMap by value, so every call deep-cloned the whole map, keys and constraints included. Pool building calls these accessors once per package per candidate, which put IndexMap::clone at 13.5% of `require laravel/laravel`. Store the maps as Rc> and return a handle. Callers that mutate the map clone it explicitly at the point of mutation, matching where PHP would separate the array. Co-Authored-By: Claude Opus 5 (1M context) --- crates/shirabe/src/repository/repository_utils.rs | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) (limited to 'crates/shirabe/src/repository/repository_utils.rs') diff --git a/crates/shirabe/src/repository/repository_utils.rs b/crates/shirabe/src/repository/repository_utils.rs index c2997f31..3df86b05 100644 --- a/crates/shirabe/src/repository/repository_utils.rs +++ b/crates/shirabe/src/repository/repository_utils.rs @@ -16,9 +16,14 @@ impl RepositoryUtils { include_require_dev: bool, mut bucket: Vec, ) -> Vec { - let mut requires: IndexMap = requirer.get_requires(); + let mut requires: IndexMap = (*requirer.get_requires()).clone(); if include_require_dev { - requires.extend(requirer.get_dev_requires()); + requires.extend( + requirer + .get_dev_requires() + .iter() + .map(|(k, v)| (k.clone(), v.clone())), + ); } for candidate in packages { -- cgit v1.3.1-4-g156e