From 1c0eb589741de4aa52ef941ff9315b34dbe48aa0 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Tue, 9 Jun 2026 00:00:12 +0900 Subject: feat(datetime): resolve datetime TODOs Introduce shim functions and constants, replacing the ad-hoc chrono format strings and parse helpers used as phase-b placeholders. Co-Authored-By: Claude Opus 4.8 (1M context) --- crates/shirabe/src/repository/vcs/fossil_driver.rs | 20 ++++++++++++++------ 1 file changed, 14 insertions(+), 6 deletions(-) (limited to 'crates/shirabe/src/repository/vcs/fossil_driver.rs') diff --git a/crates/shirabe/src/repository/vcs/fossil_driver.rs b/crates/shirabe/src/repository/vcs/fossil_driver.rs index 0ee20da..15328c0 100644 --- a/crates/shirabe/src/repository/vcs/fossil_driver.rs +++ b/crates/shirabe/src/repository/vcs/fossil_driver.rs @@ -1,10 +1,12 @@ //! ref: composer/src/Composer/Repository/Vcs/FossilDriver.php use crate::io::io_interface; -use chrono::{DateTime, Utc}; +use chrono::{DateTime, FixedOffset, Utc}; use indexmap::IndexMap; use shirabe_external_packages::composer::pcre::Preg; -use shirabe_php_shim::{PhpMixed, RuntimeException, dirname, is_dir, is_file, is_writable}; +use shirabe_php_shim::{ + DATE_RFC3339, PhpMixed, RuntimeException, dirname, is_dir, is_file, is_writable, +}; use crate::cache::Cache; use crate::config::Config; @@ -256,7 +258,10 @@ impl FossilDriver { Ok(Some(content)) } - pub fn get_change_date(&self, _identifier: &str) -> anyhow::Result>> { + pub fn get_change_date( + &self, + _identifier: &str, + ) -> anyhow::Result>> { let mut output = String::new(); self.inner.process.borrow_mut().execute_args( &["fossil", "finfo", "-b", "-n", "1", "composer.json"] @@ -268,8 +273,8 @@ impl FossilDriver { let parts: Vec<&str> = output.trim().splitn(3, ' ').collect(); let date = parts.get(1).copied().unwrap_or(""); - let date = DateTime::parse_from_rfc3339(date).map(|d| d.with_timezone(&Utc))?; - Ok(Some(date)) + let date: DateTime = shirabe_php_shim::date_create(date)?; + Ok(Some(date.fixed_offset())) } pub fn get_tags(&mut self) -> anyhow::Result> { @@ -383,7 +388,10 @@ impl crate::repository::vcs::VcsDriverInterface for FossilDriver { FossilDriver::get_file_content(self, file, identifier) } - fn get_change_date(&mut self, identifier: &str) -> anyhow::Result>> { + fn get_change_date( + &mut self, + identifier: &str, + ) -> anyhow::Result>> { FossilDriver::get_change_date(self, identifier) } -- cgit v1.3.1