From 318ea948f5932dfa7942081a269d62fd7161a9bf Mon Sep 17 00:00:00 2001
From: nsfisis <nsfisis@gmail.com>
Date: Mon, 8 Jun 2026 01:54:56 +0900
Subject: feat(phase-c): resolve reflection/downcast phase-b TODOs

Resolve category F phase-b TODOs (class-string, instanceof, get_class,
method_exists, __FILE__, Reflection API, downcast).

- VcsRepository: dispatch drivers through a VcsDriverKind enum
  (instantiate/supports/php_class_name) and add constructors to the
  concrete VCS drivers
- repository downcasts via RepositoryInterfaceHandle::downcast_rc and
  as_any (init/show commands, vcs ValidatingArrayLoader)
- BaseCommand::is_self_update_command override replaces an instanceof
- Factory::create narrows PartialComposer to ComposerHandle via as_full
- InstalledVersions gains set_self_dir/set_installed_is_local_dir,
  replacing Reflection-based static property mutation
- ClassLoader::as_array_iter ports the PHP (array) cast
- drop the unnecessary __FILE__ phar branch in self-update

application get_class(command) reclassified TODO(plugin); buffer_io
StreamableInputInterface downcast and the ValidatingArrayLoader trait
redesign left as tracked TODOs.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
---
 crates/shirabe/src/repository/vcs/perforce_driver.rs | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

(limited to 'crates/shirabe/src/repository/vcs/perforce_driver.rs')

diff --git a/crates/shirabe/src/repository/vcs/perforce_driver.rs b/crates/shirabe/src/repository/vcs/perforce_driver.rs
index d653869..0fe0f6f 100644
--- a/crates/shirabe/src/repository/vcs/perforce_driver.rs
+++ b/crates/shirabe/src/repository/vcs/perforce_driver.rs
@@ -21,6 +21,21 @@ pub struct PerforceDriver {
 }
 
 impl PerforceDriver {
+    pub fn new(
+        repo_config: IndexMap<String, shirabe_php_shim::PhpMixed>,
+        io: std::rc::Rc<std::cell::RefCell<dyn IOInterface>>,
+        config: std::rc::Rc<std::cell::RefCell<Config>>,
+        http_downloader: std::rc::Rc<std::cell::RefCell<crate::util::HttpDownloader>>,
+        process: std::rc::Rc<std::cell::RefCell<crate::util::ProcessExecutor>>,
+    ) -> Self {
+        Self {
+            inner: VcsDriverBase::new(repo_config, io, config, http_downloader, process),
+            depot: String::new(),
+            branch: String::new(),
+            perforce: None,
+        }
+    }
+
     pub fn initialize(&mut self) -> anyhow::Result<()> {
         self.depot = self
             .inner
-- 
cgit v1.3.1