From 7e31bab9ff7209c9b6d7928a581d7a449846f42e Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sun, 2 Aug 2026 17:32:43 +0900 Subject: fix(json): propagate JsonFile::encode errors instead of unwrapping PHP's JsonFile::encode throws a RuntimeException when json_encode fails; the port swallowed that into an .unwrap() marked TODO(phase-c). Return anyhow::Result from encode/encode_with_options and propagate at every call site (print_table and list_repositories become Result-returning to carry it). Co-Authored-By: Claude Fable 5 --- crates/shirabe/src/repository/vcs/vcs_driver.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'crates/shirabe/src/repository/vcs/vcs_driver.rs') diff --git a/crates/shirabe/src/repository/vcs/vcs_driver.rs b/crates/shirabe/src/repository/vcs/vcs_driver.rs index 5aa74959..3321201c 100644 --- a/crates/shirabe/src/repository/vcs/vcs_driver.rs +++ b/crates/shirabe/src/repository/vcs/vcs_driver.rs @@ -171,7 +171,7 @@ impl VcsDriverBase { pretty_print: false, ..Default::default() }, - ); + )?; self.cache.as_mut().map(|c| c.write(identifier, &encoded)); } self.info_cache.insert(identifier.to_string(), composer); @@ -237,7 +237,7 @@ pub trait VcsDriver: VcsDriverInterface { pretty_print: false, ..Default::default() }, - ); + )?; self.cache_mut().map(|c| c.write(identifier, &encoded)); } -- cgit v1.3.1